Skip to content

Refactor cli implemention and configuration #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented May 20, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

Refactoring engine behind CLI configuration, this moves all the available flags into cli.Config which encapsulate all the normalization and validation internally and helps extensively reusing config logic for different formatters.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   81.68%   81.68%           
=======================================
  Files          34       34           
  Lines        1796     1796           
=======================================
  Hits         1467     1467           
  Misses        274      274           
  Partials       55       55           
Impacted Files Coverage Δ
internal/format/factory.go 100.00% <100.00%> (ø)

@khos2ow khos2ow merged commit 04a9ef4 into terraform-docs:master May 21, 2020
@khos2ow khos2ow deleted the refactor-cli branch May 21, 2020 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants