Skip to content

feat: Support encryption_configuration for aws_sfn_state_machine #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat: Support encryption_configuration for aws_sfn_state_machine #66

merged 1 commit into from
Sep 5, 2024

Conversation

magreenbaum
Copy link
Member

Description

Support encryption_configuration for aws_sfn_state_machine.

Motivation and Context

hashicorp/terraform-provider-aws#38574
https://docs.aws.amazon.com/step-functions/latest/dg/encryption-at-rest.html

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 7f3f748 into terraform-aws-modules:master Sep 5, 2024
6 checks passed
@magreenbaum magreenbaum deleted the feat/state_machine_encryption_configuration branch September 7, 2024 13:26
@hamburml hamburml mentioned this pull request Jan 21, 2025
Closed
@antonbabenko
Copy link
Member

This PR is included in version 4.2.1 🎉

guillaumelecerf referenced this pull request Jan 24, 2025
@semantic-release-bot
chore(release): version 4.2.1 [skip ci]
3690011 
## [4.2.1](v4.2.0...v4.2.1) (2025-01-21)

### Bug Fixes

* Update CI workflow versions to latest ([#67](#67)) ([4ff7e77](4ff7e77))
@guillaumelecerf
Copy link
Contributor

guillaumelecerf commented Jan 24, 2025 •
edited
Loading

@antonbabenko: this must have been at least a minor version bump, as the required terraform provider went from >= 5.6 to >= 5.61 (in #66)

@antonbabenko
Copy link
Member

@guillaumelecerf You are right, but this PR was merged with an incorrect commit message. It should have followed the conventional commits pattern to trigger a minor release (feat: ... - correct commit message).

@guillaumelecerf
Copy link
Contributor

@guillaumelecerf You are right, but this PR was merged with an incorrect commit message. It should have followed the conventional commits pattern to trigger a minor release (feat: ... - correct commit message).

Would be nice that this could be enforced by a check, as it is done for the PR title

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magreenbaum @antonbabenko @guillaumelecerf @bryantbiggs