Skip to content

[Bug] Logic bug for create_schedule + backfill w/out trigger immediately #678

New issue
New issue
Closed
#693
Closed
[Bug] Logic bug for create_schedule + backfill w/out trigger immediately#678
#693
Labels
bugSomething isn't working
@cretz

Description

@cretz
cretz
opened on Oct 29, 2024

Describe the bug

Looking at code while developing Ruby SDK, it seems at

sdk-python/temporalio/client.py

Lines 5499 to 5507 in b162151

if input.trigger_immediately or input.backfill:
initial_patch = temporalio.api.schedule.v1.SchedulePatch(
trigger_immediately=temporalio.api.schedule.v1.TriggerImmediatelyRequest(
overlap_policy=temporalio.api.enums.v1.ScheduleOverlapPolicy.ValueType(
input.schedule.policy.overlap
),
),
backfill_request=[b._to_proto() for b in input.backfill],
)
we are always setting trigger immediately even it user set it to false but provided backfills. .NET properly does not set this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions