Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/workflow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.6
Choose a base ref
...
head repository: symfony/workflow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.2.0-BETA1
Choose a head ref
  • 10 commits
  • 31 files changed
  • 7 contributors

Commits on Jun 5, 2024

  1. use constructor property promotion

    @xabbuh
    xabbuh committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6e7c3ad View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Prefix all sprintf() calls

    @derrabus
    derrabus committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f642a9c View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Add phpdoc about exception

    @VincentLanglet
    VincentLanglet committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6a04b0a View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Update .gitattributes

    @fabpot
    fabpot committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    f83796e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Remove unused code and unnecessary else branches

    @alexandre-daubois
    alexandre-daubois committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    432717f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Remove useless code

    @alexandre-daubois
    alexandre-daubois committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a370dba View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. [Workflow] Clearer NotEnabledTransitionException message

    @that-guy-iain @nicolas-grekas
    that-guy-iain authored and nicolas-grekas committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    2147e68 View commit details
    Browse the repository at this point in the history

  2. minor #57705 [Workflow] Clearer NotEnabledTransitionException messa… 

    …ge (that-guy-iain)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[Workflow] Clearer `NotEnabledTransitionException` message

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT

The current exception message is somewhat confusing as it makes you think the transition is not enabled at all within the workflow. This can/does lead to people trying to debug a config issue. While the problem being encountered issue is that the transition can't be applied due to the current state of the supported class/object.

Hopefully, this makes it a bit clearer.

Commits
-------

942ca5acc2 [Workflow] Clearer `NotEnabledTransitionException` message
    @nicolas-grekas
    nicolas-grekas committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    82a5794 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix $this calls to static ones when relevant

    @alexandre-daubois
    alexandre-daubois committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7649fb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch '7.1' into 7.2 

    * 7.1:
  Add PR template and auto-close PR on subtree split repositories
    @nicolas-grekas
    nicolas-grekas committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c284a65 View commit details
    Browse the repository at this point in the history
Loading