[Console][QuestionHelper] add optional timeout for human interaction #61092
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
stof
reviewed
Jul 10, 2025
janedbal
commented
Jul 10, 2025
OskarStark
changed the title
OskarStark
reviewed
Jul 10, 2025
Co-authored-by: Oskar Stark <oskarstark@googlemail.com>
Co-authored-by: Anderson Müller <anderson.a.muller@gmail.com>
|
Any chance this get approved/merged soon? I believe those CI failures are not relevant. Thanks |
OskarStark
reviewed
Jul 18, 2025
Comment on lines
+513
to
+514
| $plural = 1 === $timeoutSeconds ? '' : 's'; | ||
| throw new MissingInputException("Timed out after waiting for input for $timeoutSeconds second$plural."); |
There was a problem hiding this comment.
Suggested change
| $plural = 1 === $timeoutSeconds ? '' : 's'; | |
| throw new MissingInputException("Timed out after waiting for input for $timeoutSeconds second$plural."); | |
| throw new MissingInputException(\sprintf('Timed out after waiting for input for %d %s.', $timeoutSeconds, $timeoutSeconds === 1 ? 'second' : 'seconds')); |
?
OskarStark
reviewed
Jul 18, 2025
|
|
||
| /** | ||
| * The timeout is the maximum time the user has to answer the question. | ||
| * If the user does not answer within this time, an exception will be thrown. |
There was a problem hiding this comment.
Suggested change
| * If the user does not answer within this time, an exception will be thrown. |
this logic is part of the questionHelper, not the setter.
OskarStark
reviewed
Jul 18, 2025
| @@ -38,6 +38,7 @@ class Question | |||
| private ?\Closure $normalizer = null; | |||
| private bool $trimmable = true; | |||
| private bool $multiline = false; | |||
| private ?int $timeoutSeconds = null; | |||
There was a problem hiding this comment.
Suggested change
| private ?int $timeoutSeconds = null; | |
| private ?int $timeout = null; |
same for set and get methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About: