-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Add min
and max
in both error messages of LengthValidator
#60805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.4
Are you sure you want to change the base?
Conversation
d18fd05
to
6182584
Compare
min
and max
in both error messages of LengthValidator
6182584
to
4a539fb
Compare
The Tests on 8.2 high-deps are failing because this PR How do I solve this ? |
a521b0f
to
f51245e
Compare
Friendly ping @nicolas-grekas you might know how to solve the failure #60805 (comment) Test are failing but I feel like I cannot fix them since it runs the 6.4 version and I'm on the 7.4 branch... |
f51245e
to
8df3197
Compare
Looks good. I noticed some failures are related to these changes. |
8df3197
to
9ec2a5e
Compare
Hi ; I rebased but I dunno how to fix the test. See https://github.com/symfony/symfony/actions/runs/16356617489/job/46216379960?pr=60805 The Unit test 8.2 high-deps is checking out the code on Symfony 6.4
So this file changes are lost And of course tests are failing since they don't have the Any clue how to fix this @Spomky ? |
This would allow to use the same message for a Length constraint which say
"The length needs to be between {{ min }} and {{ max }}".