[DoctrineBridge][Form] Fix EntityType memory leak
#44497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
commented
Dec 7, 2021
| @@ -97,6 +98,15 @@ public function boot() | |||
| } | |||
| } | |||
|
|
|||
| public function shutdown() | |||
There was a problem hiding this comment.
This fixes the issue but I don't expect this is the proper solution. I'd like some input on where this fix should be made.
| parent::shutdown(); | ||
|
|
||
| if (class_exists(AbstractStaticOption::class)) { | ||
| AbstractStaticOption::reset(); |
There was a problem hiding this comment.
would adding this call to DoctrineType::reset() fix the leak for you?
|
Closing as this is certainly not the appropriate patch, if any is needed at all. See linked issue for next steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 5.1 (#30994) introduced a memory leak (at least for functional tests) when using the EntityType. See #40965 (comment) for more details.