[PropertyInfo] Extract from default value doesn't set collection boolean #38446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korbeil
force-pushed
the
fix/no-collection-extract-default-value
branch
from
de624d5 to
f6ab0a7
Compare
lyrixx
approved these changes
Oct 6, 2020
Korbeil
force-pushed
the
fix/no-collection-extract-default-value
branch
2 times, most recently
from
671d0f7 to
cac6fe2
Compare
Korbeil
force-pushed
the
fix/no-collection-extract-default-value
branch
from
cac6fe2 to
33d37e5
Compare
dunglas
approved these changes
Oct 6, 2020
|
Thank you @Korbeil. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the issue by checking if the type is an array or not and setting the collection boolean based on this check.