[2.7][Form] Added choice_label_attr option to choice type #14413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5503804.
* 2.7: [HttpKernel] fixed a regression when no exception listeners are registered renamed some confusing tests propel/propel1 is now useless bumped Symfony version to 2.7.0 updated VERSION for 2.7.0-BETA1 updated CHANGELOG for 2.7.0-BETA1 [2.3] Fix @link annotations [2.7] For @link annotations [2.6] Fix @link annotations [2.7][Console] Count the array instead of [Config][cache factory] check type of callback argument. Fix javascript [2.3][Translation] test refresh cache when resources File change. Added deprecation message and original color back [Translator] Cache does not take fallback locales into consideration
…ort number option. (aitboudad) This PR was merged into the 2.8 branch. Discussion ---------- [FrameworkBundle][Server Command] add address port number option. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ This allow running server without repeating `127.0.0.1` each time, in the most of case we only change the port number. * Before ``` app/console server:start 127.0.0.1:8080 ``` * After ``` app/console server:start -p 8080 ``` Commits ------- fbe1a43 [FrameworkBundle][Server Command] add address port number option.
This PR was merged into the 2.8 branch. Discussion ---------- [Translation] added FileLoader. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 3694e5e [Translation] added FileLoader.
- extend new choice_attr option to labels for radio buttons and checkboxes when choice field type is expanded. - accepts same arguments as choice_attr : string, array, callable and null by default
|
BC break: yes since it changes an interface |
This PR was merged into the 2.8 branch.
Discussion
----------
[VarDumper] Added support for SplFileInfo
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
Before:
```
SplFileInfo {#3}
```
After:
```
SplFileInfo {#3
path: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures"
filename: "grisou.jpg"
basename: "grisou.jpg"
pathname: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg"
extension: "jpg"
realPath: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg"
aTime: 2015-04-20 23:21:15
mTime: 2014-08-17 15:37:36
cTime: 2015-04-20 23:09:51
inode: 12197643
size: 966553
perms: 0100750
owner: 1000
group: 1000
type: "file"
writable: true
readable: true
executable: true
file: true
dir: false
link: false
}
```
For a link:
```
SplFileInfo {#3
path: ""
filename: "link"
basename: "link"
pathname: "link"
extension: ""
realPath: "/home/greg/dev/github.com/symfony/var-dumper/composer.json"
aTime: 2015-04-20 23:39:15
mTime: 2015-04-20 23:39:15
cTime: 2015-04-20 23:39:15
inode: 11272232
size: 967
perms: 0100644
owner: 1000
group: 1000
type: "link"
writable: true
readable: true
executable: false
file: true
dir: false
link: true
linkTarget: "composer.json"
}
```
For a remote file:
```
SplFileInfo {#3
path: "http://google.com"
filename: "foobar.php"
basename: "foobar.php"
pathname: "http://google.com/foobar.php"
extension: "php"
realPath: false
writable: false
readable: false
executable: false
file: false
dir: false
link: false
}
```
For a CSV:
```
SplFileObject {#3
path: ""
filename: "test.csv"
basename: "test.csv"
pathname: "test.csv"
extension: "csv"
realPath: "/home/greg/dev/github.com/symfony/var-dumper/test.csv"
aTime: 2015-04-21 12:55:07
mTime: 2015-04-21 12:55:07
cTime: 2015-04-21 12:55:07
inode: 11272237
size: 0
perms: 0100644
owner: 1000
group: 1000
type: "file"
writable: true
readable: true
executable: false
file: true
dir: false
link: false
csvControl: array:2 [
0 => ","
1 => """
]
flags: SKIP_EMPTY|READ_CSV
maxLineLen: 0
fstat: array:7 [
"dev" => 64513
"ino" => 11272237
"nlink" => 1
"rdev" => 0
"blksize" => 4096
"blocks" => 0
"…" => "…20"
]
eof: false
key: 0
}
Commits
-------
e75c233 [VarDumper] Added support for SplFileObject
eb50b13 [VarDumper] Added support for SplFileInfo
…d if possible (lyrixx)
This PR was merged into the 2.8 branch.
Discussion
----------
[Console] Bind the closure (code) to the Command if possible
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| License | MIT
| Doc PR | ~
This allow this kind of code:
```php
#!/usr/bin/env php
<?php
require __DIR__.'/vendor/autoload.php';
use Symfony\Component\Console\Application;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
$application = new Application();
$application->add((new Command('process')))
->setDescription('Play all other commands')
->setCode(function (InputInterface $input, OutputInterface $output) use ($application) {
$application = $this->getApplication();
$help = $application->find('help');
$output->writeln($help->getHelp());
})
;
$application->run();
```
Commits
-------
ff4424a [Console] Bind the closure (code) to the Command if possible
…rays (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Allow preserving a subset of cut arrays | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 208ca94 [VarDumper] Allow preserving a subset of cut arrays
* 2.7: (40 commits) [Debug] Fix ClassNotFoundFatalErrorHandler candidates lookups [2.6][Translator] Extend, refactor and simplify Translator tests. Update DebugClassLoader.php inject asset packages in assets helper service [travis] Do not exclude legacy tests on 2.7 [HttpFoundation] remove getExtension method [2.6][Translation] fix legacy tests. [Form] Removed remaining deprecation notices in the test suite [Form] Moved deprecation notice triggers to file level [Debug] Map PHP errors to LogLevel::CRITICAL [Routing][DependencyInjection] Support .yaml extension in YAML loaders [DX] improve file loader error for router/other resources in bundle [FrameworkBundle] Initialize translator with the default locale. [FrameworkBundle] Fix Routing\DelegatingLoader resiliency to fatal errors [2.7][Translation] remove duplicate code for loading catalogue. [2.6][Translation] remove duplicate code for loading catalogue. [HttpKernel] Cleanup ExceptionListener CS fixes [DependencyInjection] Show better error when the Yaml component is not installed [2.3] SCA for Components - reference mismatches ...
* 2.7: [Debug] Fix deprecated use of DebugClassLoader Revert "[HttpKernel] Throw a LogicException when kernel.exception does not led to a Response" [Validator] Fixed Choice when an empty array is used in the "choices" option
* 2.7: Fix test
* 2.7: [FrameworkBundle] Fix test related to PSR-4
…g output (nicolasdewez) This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes symfony#14473). Discussion ---------- [DX] Minor improvement for the translation:debug output | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#13874 Commits ------- b941bd3 Changed output for translation:debug command
…g:translation command symfony#14237 (sgehrig) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes symfony#14320). Discussion ---------- [Translation] added an --all option to the debug:translation command symfony#14237 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#14237 | License | MIT | Doc PR | - - [ ] submit changes to the documentation This PR adds an `--all` option the `debug:translation` command to enable debugging translations in all registered bundles *AND* the app directory. Commits ------- 0e7fe79 added the --all option to the debug:translation command
…anslator (damienalexandre) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes symfony#15139). Discussion ---------- [Translation] Add parameters to DataCollectorTranslator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The new translation web profiler panel miss a important piece of information: the parameters that can be used for placeholders. This PR add parameters in the collected translations and display them in the WebProfiler translation list.  Original idea by my team-mate @joelwurtz 🤘 Commits ------- 85ae760 [Translation] Add parameters to DataCollectorTranslator
* 2.7: fixed merge
* 2.7: fixed tests fixed some tests Remove excess whitespace
… latest request (xelaris) This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes symfony#14264). Discussion ---------- [WebProfilerBundle] Add link to show profile of latest request | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR adds a "View latest" link next to "View last 10" to enable quick access to the profile of the latest request. This is useful especially when using the profiler along with a REST client. After sending a new request it is now possible to view the latest profile with just one click. Commits ------- b65d0a2 [WebProfilerBundle] Add link to show profile of latest request
…(jakzal) This PR was merged into the 2.8 branch. Discussion ---------- [DependencyInjection] Forbid container cloning | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#15261 | License | MIT | Doc PR | - Commits ------- ba12904 [DependencyInjection] Forbid container cloning
* 2.7: [HttpFoundation] Fix Response::closeOutputBuffers() for HHVM 3.3 [Console] Set QuestionHelper max attempts in tests [Form] Fix a BC break in the entity fix broken ChoiceQuestion bumped Symfony version to 2.7.3 updated VERSION for 2.7.2 updated CHANGELOG for 2.7.2 bumped Symfony version to 2.6.11 updated VERSION for 2.6.10 updated CHANGELOG for 2.6.10 [PropertyAccess] setValue & isWritable loops must only stops on reference and object. References can also be arrays and if the loop stops the value is never set in the object. (Breaks since 2.6.5 commit e3e4695)
This allows to remove references to all services during shutdown, giving much more chances to destruct services and the container through refcounting rather than waiting GC, as it will break cycles between the container and container-aware services.
* 2.7: [HttpKernel] Fix lowest dep [Security] fix check for empty usernames [Form] updated exception message of ButtonBuilder::setRequestHandler() [travis] Fix deps=high jobs Fix typo 'assets.package' => 'assets.packages' in UPGRADE-2.7 [Serializer] Simplify AbstractNormalizer::prepareForDenormalization() [HttpFoundation] [PSR-7] Allow to use resources as content body and to return resources from string content [DependencyInjection] Remove unused code in XmlFileLoader [HttpFoundation] Behaviour change in PHP7 for substr bumped Symfony version to 2.3.32 updated VERSION for 2.3.31 update CONTRIBUTORS for 2.3.31 updated CHANGELOG for 2.3.31 Conflicts: src/Symfony/Bridge/Twig/composer.json src/Symfony/Bundle/FrameworkBundle/composer.json src/Symfony/Component/HttpKernel/composer.json
This PR was merged into the 2.8 branch. Discussion ---------- [2.8] Fix 3.0 incompatible deps | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This should fix the failing the deps=2.8 tests on master. Commits ------- 753812e [2.8] Fix 3.0 incompatible deps
…nterfaces to Security\Http (WouterJ) This PR was squashed before being merged into the 2.8 branch (closes symfony#15131). Discussion ---------- [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http Description --- The `SimpleFormAuthenticatorInterface` and `SimplePreAuthenticatorInterface` rely on `Request`, which means it's a Http land class. This means they don't belong in core. Having a form login that doesn't depend on the request is an option as well (e.g. a console application might use the question helper to implement a "form" login). However, then there is a need for a new abstraction of the request. I don't think it's worth it. Furthermore, the only classes typehinting/relying on this interfaces can be found in `Security\Http`. Implementation --- The new interfaces extend the old ones for better backwards compability. Symfony doesn't trigger deprecation errors for interfaces, see symfony@6f57b7b PR Info Table --- | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- ebb2064 [Security] Moved Simple{Form,Pre}AuthenticatorInterfaces to Security\Http
This PR was merged into the 2.8 branch. Discussion ---------- Implement resettable containers | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | small one | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#13448 | License | MIT | Doc PR | n/a This allows to release remove references to all services during shutdown, giving much more chances to destruct services and the container through refcounting rather than waiting GC, as it will break cycles between the container and container-aware services. There is a small BC break for a very edge case: if someone keeps a reference to the container and then shutdowns the kernel, the container would now be cleared and so would not work as intended anymore. But I don't think it is a supported use case. If you shutdown the kernel, the container of this kernel is released by the kernel and should not be used anymore IMO. Thus, shutting down the kernel generally does not happen except during tests on teardown. I'm not sure a doc PR is needed here: users of the fullstack framework should never use this feature (the kernel is using it for them). What do you think @weaverryan ? Commits ------- 4457745 Implement resettable containers
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fix not-BC test assertion | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The 2.6 branch is failing because of this case for `Validation::API_VERSION_2_4`, that can't work because `$this->context` is not a mock object, thus has no "expect" method. See https://travis-ci.org/symfony/symfony/jobs/72100346#L2902 This got unnoticed because only 2.6 is testing the 2.4 validator api. Commits ------- 5ef7ae9 [Form] Fix not-BC test assertion
* 2.7: [Twig+FrameworkBundle] Fix forward compat with Form 2.8 [2.6] Static Code Analysis for Components [Security/Http] Fix test relying on a private property [Serializer] Fix bugs reported in symfony@b5990be#commitcomment-12301266 Conflicts: src/Symfony/Bridge/Twig/Resources/views/Form/form_div_layout.html.twig src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/widget_attributes.html.php src/Symfony/Component/Security/Http/Tests/Firewall/AnonymousAuthenticationListenerTest.php
* 2.7: [Yaml] throw a ParseException on invalid data type [TwigBridge] type-dependent path discovery Resources as string have the same problem Introduce failing test case when a SplFileInfo object is passed to the extract() method in the TwigExtractor. symfony#15331 add infos about deprecated classes to UPGRADE-3.0 [Asset] removed unused private property. [Security] removed useless else condition in SwitchUserListener class. [travis] Tests deps=low with PHP 5.6 [Console] Fix console output with closed stdout
|
ping @HeahDude :) |
HeahDude
changed the title
- extend new choice_attr option to labels for radio buttons and checkboxes when choice field type is expanded. - accepts same arguments as choice_attr : string, array, callable and null by default # Conflicts: # src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.ph p # src/Symfony/Component/Form/ChoiceList/Factory/ChoiceListFactoryInterface .php # src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.p hp # src/Symfony/Component/Form/ChoiceList/Factory/PropertyAccessDecorator.ph p # src/Symfony/Component/Form/ChoiceList/View/ChoiceView.php # src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php # src/Symfony/Component/Form/Tests/ChoiceList/Factory/CachingFactoryDecora torTest.php # src/Symfony/Component/Form/Tests/ChoiceList/Factory/PropertyAccessDecora torTest.php
HeahDude
changed the title
|
Closing in favor of #15447 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkboxes when choice field type is expanded.
null by default