Skip to content

Streamline one more exception for the bridges regarding option classes #59120

New issue
New issue
Closed
#59234
Closed
Streamline one more exception for the bridges regarding option classes#59120
#59234
Labels
Good first issueIdeal for your first contribution! (some Symfony experience may be required)Hack DayNotifier
Milestone
7.3
@OskarStark

Description

@OskarStark
OskarStark
opened on Dec 7, 2024

Take for example the GoIpTransport, it contains the following lines:

symfony/src/Symfony/Component/Notifier/Bridge/GoIp/GoIpTransport.php

Lines 65 to 67 in c98b02a

if (($options = $message->getOptions()) && !$options instanceof GoIpOptions) {
throw new LogicException(\sprintf('The "%s" transport only supports an instance of the "%s" as an option class.', __CLASS__, GoIpOptions::class));
}

I would like to have a dedicated exception class UnsupportedOptionsException, basically the same as I did in

This could be done for all bridges which already use options.

Note

It is important to also raise the notifier version to 7.3 in the composer.json files where this new exception is used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good first issueIdeal for your first contribution! (some Symfony experience may be required)Hack DayNotifier

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions