Skip to content

[Notifier] Some Transport aren't using event dispatcher #52997

@rdavaillaud

Description

@rdavaillaud

Symfony version(s) affected

5.4, 6.4, 7.x

Description

Some Notifier transport factories are redefining the class constructor, but aren't passing the HttpClient nor the EventDispatcher.
As a result, those transports are not providing Notifier event hooks.
I think they should in order to act the same as other.

  • MercureTransportFactory
  • FakeSmsTransportFactory
  • FakeChatTransportFactory

How to reproduce

Use FakeSms bridge, and add an event listener on MessageEvent::class.

Possible Solution

PR added

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions