-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Closed
Labels
DoctrineBridgeHelp wantedIssues and PRs which are looking for volunteers to complete them.Issues and PRs which are looking for volunteers to complete them.Keep openStatus: Reviewed
Description
Description
Since the first BETA for DBAL 4 was just released I'm looking into making https://github.com/dmaicher/doctrine-test-bundle compatible with it.
On Symfony's side I noticed this error:
In Connection.php line 82:
[Symfony\Component\ErrorHandler\Error\FatalError]
Compile Error: Declaration of Symfony\Bridge\Doctrine\Middleware\Debug\Connection::beginTransaction(): bool must be compatible with Doctrine\DBAL\Driver\Middleware\AbstractConnectionMiddleware::beginTr
ansaction(): void
Exception trace:
at /var/www/doctrine-test-bundle/vendor/symfony/doctrine-bridge/Middleware/Debug/Connection.php:82
The return type was changed to : void
on DBAL 4. This also affects rollback()
and commit()
.
I guess for now this is not high priority as the public API might still change for DBAL 4. But I just wanted to register this issue already for awareness.
Metadata
Metadata
Assignees
Labels
DoctrineBridgeHelp wantedIssues and PRs which are looking for volunteers to complete them.Issues and PRs which are looking for volunteers to complete them.Keep openStatus: Reviewed