[PHPUnitBridge] ignoreFile does not allow comments #45918
Description
Symfony version(s) affected
6.1.0
Description
The newly introduced ignoreFile does not accept lines starting with '#' as comments.
How to reproduce
Use an ignoreFile like
# PHPUnit 9.
/"PHPUnit\\Framework\\TestListener".*is deprecated/
/"PHPUnit\\Framework\\TestListenerDefaultImplementation".*is deprecated/
/xx"PHPUnit\\TextUI\\DefaultResultPrinter".*is considered internal/
you get an error like
Invalid pattern found in "/var/www/d10/core/deprecation-ignore.txt" on line "1": No ending delimiter '#' found
PHP Fatal error: Uncaught RuntimeException: Invalid pattern found in "/var/www/d10/core/deprecation-ignore.txt" on line "1": No ending delimiter '#' found in /var/www/d10/vendor/symfony/phpunit-bridge/DeprecationErrorHandler/Configuration.php:124
Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler\Configuration::Symfony\Bridge\PhpUnit\DeprecationErrorHandler\{closure}()
#1 /var/www/d10/vendor/symfony/phpunit-bridge/DeprecationErrorHandler/Configuration.php(129): preg_match()
#2 /var/www/d10/vendor/symfony/phpunit-bridge/DeprecationErrorHandler/Configuration.php(345): Symfony\Bridge\PhpUnit\DeprecationErrorHandler\Configuration->__construct()
#3 /var/www/d10/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php(272): Symfony\Bridge\PhpUnit\DeprecationErrorHandler\Configuration::fromUrlEncodedString()
#4 /var/www/d10/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php(185): Symfony\Bridge\PhpUnit\DeprecationErrorHandler->getConfiguration()
#5 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->shutdown()
#6 {main}
thrown in /var/www/d10/vendor/symfony/phpunit-bridge/DeprecationErrorHandler/Configuration.php on line 124
Apparently, parsing of the ignoreFile for patterns to be ignored does not consider lines starting with '#' as a comment.
Possible Solution
No response
Additional Context
No response