-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Description
Symfony version(s) affected
4.4.37
Description
Greetings,
In this commit f7abdec#diff-41ab8decc1c9a80a9eddc61fb2c29602aaf1a82c80d0a0dfe45bab694a56b9ae the attribute was added, but it didn't land to 4.4 branch, while this one 1261a41#diff-41ab8decc1c9a80a9eddc61fb2c29602aaf1a82c80d0a0dfe45bab694a56b9ae fixing the RedisSessionHandler::gc()
has landed to 4.4.
Was it a mistake or it was done intentionally? Shall I open a PR to fix just updateTimestamp()
method, or there is a possibility the missing commit will be merged into 4.4?
In PHP 8.1 it causes:
Deprecated: Return type of Symfony\Component\HttpFoundation\Session\Storage\Handler\RedisSessionHandler::updateTimestamp($sessionId, $data) should either be compatible with SessionUpdateTimestampHandlerInterface::updateTimestamp(string $id, string $data): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /app/vendor/symfony/http-foundation/Session/Storage/Handler/RedisSessionHandler.php on line 119
How to reproduce
Nothing to reproduce.
Possible Solution
No response
Additional Context
No response