Skip to content

[HttpFoundation] Deprecate session.upload_progress.* and url_rewriter.tags as valid configuration options. #43284

@kafene

Description

@kafene

Description
While perusing the source of HttpFoundation on this beautiful Friday evening, I noticed that it permits configuration of the session.upload_progress.* and url_rewriter.tags ini settings.

In the case of session.upload_progress.* - these are PHP_INI_PERDIR options and can not be configured at runtime with ini_set. Future Symfony versions should drop them as valid session options.

In the case of url_rewriter.tags - the PHP docs note that as of PHP 7.1.0, it is no longer used for session configuration and that setting is now session.trans_sid_tags.

Both the upload_progress and url_rewriter.tags options are still present in the 6.0 branch, so I'm suggesting that they be deprecated.

Example

> php -n -d'extension=readline.so' -d'session.upload_progress.enabled=On' -a
Interactive mode enabled

php > var_dump(ini_get('session.upload_progress.enabled'));
string(1) "1"
php > var_dump(ini_set('session.upload_progress.enabled', '0'));
bool(false)
php > var_dump(ini_get('session.upload_progress.enabled'));
string(1) "1"

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions