Skip to content

[RFC] Move PassportInterface::checkIfCompletelyResolved to service layer? #40491

New issue
New issue
Closed
#40567
Closed
[RFC] Move PassportInterface::checkIfCompletelyResolved to service layer?#40491
#40567
Labels
RFCRFC = Request For Comments (proposals about features that you want to be discussed)Security
@ro0NL

Description

@ro0NL
ro0NL
opened on Mar 16, 2021

I fail to see why

symfony/src/Symfony/Component/Security/Http/Authenticator/Passport/PassportTrait.php

Lines 46 to 53 in 21d4c09

public function checkIfCompletelyResolved(): void
{
foreach ($this->badges as $badge) {
if (!$badge->isResolved()) {
throw new BadCredentialsException(sprintf('Authentication failed security badge "%s" is not resolved, did you forget to register the correct listeners?', \get_class($badge)));
}
}
}

should be part of the PassportInterface contract, instead of leveraging eg. AuthenticatorManagerInterface 🤔

can a passport really be self-checking in that regard? is it an implementation detail of the manager?

Metadata

Metadata

Assignees

No one assigned

    Labels

    RFCRFC = Request For Comments (proposals about features that you want to be discussed)Security

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions