-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Closed
Description
Originally posted by @OskarStark in #39457 (comment)
Oh I've done that, but we have a "bigger" problem here.
symfony/src/Symfony/Component/Notifier/Transport/Dsn.php
Lines 104 to 107 in 026da8b
public function getOriginalDsn(): string | |
{ | |
return $this->dsn; | |
} |
should return string
, but it contains null
whenever you instantiate the Dsn
class vie new
instead of fromString()
symfony/src/Symfony/Component/Notifier/Transport/Dsn.php
Lines 63 to 64 in 026da8b
$dsnObject = new self($parsedDsn['scheme'], $parsedDsn['host'], $user, $password, $port, $query, $path); | |
$dsnObject->dsn = $dsn; |
One option could be to change the return type to ?string
or make the constructor private and only instantiate through fromString
. Currently new Dsn(...)
is only used in tests. 🤔