Skip to content

[Messenger][SQS] Prevent calling getQueueUrl() when DSN is a SQS queue URL #38849

@natepage

Description

@natepage

Description
In #37306 we added the support for SQS queue URL as DSN, however we're still calling getQueueUrl() internally, we could prevent that request as we already know the queue URL in that case.

I'm happy to work on a PR for this, but I would like to have some feedback about how we would like this to be implemented 😄

Idea
In Connection, to allow this to work with both fromDsn() and the constructor, I was thinking about adding an option queue_url which defaults to null.

This way someone instantiating the connection directly has the ability to pass that option, and in fromDsn() we can set this option based on $dsn.

Then we just need to update the getQueueUrl() method to use the option if set.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions