Skip to content

RedisStore does not follow the StoreInterface for waitAndSave #28694

@nesl247

Description

@nesl247

Symfony version(s) affected: 4.1.*

Description
RedisStore does not properly follow StoreInterface's docblock.

Possible Solution
Instead of throwing InvalidArgumentException it should throw `NotSupportedException

Additional context
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Lock/StoreInterface.php#L37
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Lock/Store/RedisStore.php#L77

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions