-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Closed
Labels
DependencyInjectionRFCRFC = Request For Comments (proposals about features that you want to be discussed)RFC = Request For Comments (proposals about features that you want to be discussed)
Description
Q | A |
---|---|
Bug report? | no |
Feature request? | yes |
BC Break report? | yes |
RFC? | no |
Symfony version | 3.4 |
In Symfony 3.3, we stopped lowercasing the IDs of services. I propose to do the same for the container parameters in 3.4.
If you open the compiled service container, you'll find this:
public function getParameter($name)
{
$name = strtolower($name);
// ...
}
public function hasParameter($name)
{
$name = strtolower($name);
// ...
}
This means that container parameters are case insensitive in practice. I think it's better if Symfony doesn't change anything defined by the user, such as the name of the container parameters. This would also save us tens of strtolower()
calls.
Simperfit, ro0NL and TomasVotruba
Metadata
Metadata
Assignees
Labels
DependencyInjectionRFCRFC = Request For Comments (proposals about features that you want to be discussed)RFC = Request For Comments (proposals about features that you want to be discussed)