-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Closed
Labels
RFCRFC = Request For Comments (proposals about features that you want to be discussed)RFC = Request For Comments (proposals about features that you want to be discussed)WebProfilerBundle
Description
Q | A |
---|---|
Bug report? | no |
Feature request? | no |
BC Break report? | no |
RFC? | yes |
Symfony version | 3.4 |
This config option allows to display the debug toolbar at the top of the browser window instead of the default bottom position.
In the past we required this option because the old profiler displayed the toolbar at the top ... but the new profiler no longer needs it because it doesn't display the toolbar.
Although this may look as a small option, it requires some code to manage it:
- The config code to define and validate the
position
option inweb_profiler
- The toolbarPosition argument is passed around in some profiler controllers
- The CSS styles must define special styles when the toolbar is at the top
- We even create a container parameter for this!
web_profiler.debug_toolbar.position
Now that we don't need this option for ourselves, I propose to deprecate it in 3.4 and remove it in 4.0.
ro0NL, stloyd, nicolas-grekas, linaori, yceruto and 2 morefritzmg
Metadata
Metadata
Assignees
Labels
RFCRFC = Request For Comments (proposals about features that you want to be discussed)RFC = Request For Comments (proposals about features that you want to be discussed)WebProfilerBundle