-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Closed
Labels
Description
If you include symfony/http-kernel
and use the bundle system, it will fail unless you have manually required symfony/finder
due to this line: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Bundle/Bundle.php#L171
But actually, the only thing that uses this is Application
from FrameworkBundle
. So, the dependency should maybe be added to symfony/framework-bundle
... but really, it's a bit odd that the Bundle
class in http-kernel
holds the registerCommands()
logic.
Options:
A) Add symfony/finder
to symfony/http-kernel
: (seems like overkill, but the most technically correct)
B) Add symfony/finder
to symfony/framework-bundle
(practical)
C) Something else :)
Thanks!