-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Comparing changes
Open a pull request
base repository: symfony/symfony
base: v5.4.36
head repository: symfony/symfony
compare: v5.4.37
- 13 commits
- 10 files changed
- 6 contributors
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6a229c7 - Browse repository at this point
Copy the full SHA 6a229c7View commit details -
Enhance error handling in StaticPrefixCollection for compatibility wi…
…th libpcre2-10.43 The error handling function in the StaticPrefixCollection class has been extended. A new check for 'Compilation failed: length of lookbehind assertion is not limited' message error was added to improve the error capture process.
Configuration menu - View commit details
-
Copy full SHA for 7183330 - Browse repository at this point
Copy the full SHA 7183330View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eadc22 - Browse repository at this point
Copy the full SHA 9eadc22View commit details -
bug #54080 [Routing] Enhance error handling in StaticPrefixCollection…
… for compatibility with libpcre2-10.43 (Lustmored) This PR was merged into the 5.4 branch. Discussion ---------- [Routing] Enhance error handling in StaticPrefixCollection for compatibility with libpcre2-10.43 The error handling function in the StaticPrefixCollection class has been extended. A new check for 'Compilation failed: length of lookbehind assertion is not limited' message error was added to improve the error capture process. | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54067 | License | MIT Recent changes in libpcre2 have changed the error message we are trying to catch in StaticPrefixCollection. The change comes from this commit (please take a look at changes in `src/pcre2_error.c`): PCRE2Project/pcre2@1e78b77 This PR checks for both possible error messages for backwards-compatible way of handling errors. I did not add any tests as current tests are throwing PHP warnings when run with newer libpcre2, which are gone after the proposed change and I'm unsure how to proceed with that fact. Commits ------- 7183330 Enhance error handling in StaticPrefixCollection for compatibility with libpcre2-10.43
Configuration menu - View commit details
-
Copy full SHA for dc1da9c - Browse repository at this point
Copy the full SHA dc1da9cView commit details -
bug #54081 [DoctrineBridge] Safeguard dynamic access to Doctrine meta…
…data properties (derrabus) This PR was merged into the 5.4 branch. Discussion ---------- [DoctrineBridge] Safeguard dynamic access to Doctrine metadata properties | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54077 | License | MIT Commits ------- 9eadc22 Safeguard dynamic access to Doctrine metadata properties
Configuration menu - View commit details
-
Copy full SHA for ac07f3e - Browse repository at this point
Copy the full SHA ac07f3eView commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9407a1b - Browse repository at this point
Copy the full SHA 9407a1bView commit details
Commits on Feb 29, 2024
-
bug #54102 [HttpClient] Fix deprecation on PHP 8.3 (nicolas-grekas)
This PR was merged into the 5.4 branch. Discussion ---------- [HttpClient] Fix deprecation on PHP 8.3 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 9407a1b [HttpClient] Fix deprecation on PHP 8.3
Configuration menu - View commit details
-
Copy full SHA for bb7c711 - Browse repository at this point
Copy the full SHA bb7c711View commit details
Commits on Mar 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4155f66 - Browse repository at this point
Copy the full SHA 4155f66View commit details -
minor #54086 [Security][Tests] Update functional tests to better refl…
…ect end-user scenarios (llupa) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Security][Tests] Update functional tests to better reflect end-user scenarios | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Pinging `@wouterj` This PR is related to #53851 's Context. > A person going through Symfony docs for the first time wanted to create their own LoginFormType as a next step in their learning Symfony journey and noticed that you can submit empty username/password with form login. > > They wanted to disallow this and tried to add validation. To validate a login form is not so straight forward as it either needs to be done with a custom authenticator (complex validation) or user provider if the data checks are simple. Following comments: #53851 (comment) > Given the broken high-deps build, I wonder if this shouldn't even be done with a deprecation notice before making it throw in 8.0? #53851 (comment) > These are 3 tests submitting an empty login form to trigger a CSRF token error. This new condition now takes precedence, meaning it returns the wrong error. I don't think that is something we have to worry about (in both situations, login errors), it rather reveals a bad test in our codebase. I can't think of a use-case that would result in success and will become a failure after this merge. #53851 (comment) > I think we need consensus on whether we find this a hard BC break that deserves a smooth upgrade path, but the test need to be fixed whatever the conclusion Commits ------- 4155f66 [Security][Tests] Update functional tests to better reflect end-user scenarios
Configuration menu - View commit details
-
Copy full SHA for 1f386a3 - Browse repository at this point
Copy the full SHA 1f386a3View commit details
Commits on Mar 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9b03f27 - Browse repository at this point
Copy the full SHA 9b03f27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d1867d - Browse repository at this point
Copy the full SHA 8d1867dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e40319 - Browse repository at this point
Copy the full SHA 3e40319View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f8d2f1 - Browse repository at this point
Copy the full SHA 3f8d2f1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.4.36...v5.4.37