minor #58748 [Process] ignore case of built-in cmd.exe commands (xabbuh)

nicolas-grekas · nicolas-grekas · commit f9c3a0037df0 · 2024-11-04T10:38:52.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Process] ignore case of built-in cmd.exe commands | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 278cabd ignore case of built-in cmd.exe commands
diff --git a/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php b/src/Symfony/Component/Process/Tests/ExecutableFinderTest.php
@@ -166,9 +166,9 @@ public function testFindBuiltInCommandOnWindows()
         }
 
         $finder = new ExecutableFinder();
-        $this->assertSame('rmdir', $finder->find('RMDIR'));
-        $this->assertSame('cd', $finder->find('cd'));
-        $this->assertSame('move', $finder->find('MoVe'));
+        $this->assertSame('rmdir', strtolower($finder->find('RMDIR')));
+        $this->assertSame('cd', strtolower($finder->find('cd')));
+        $this->assertSame('move', strtolower($finder->find('MoVe')));
     }
 
     private function assertSamePath($expected, $tested)

Original file line number	Diff line number	Diff line change
`@@ -166,9 +166,9 @@ public function testFindBuiltInCommandOnWindows()`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`$finder = new ExecutableFinder();`
`169`		`- $this->assertSame('rmdir', $finder->find('RMDIR'));`
`170`		`- $this->assertSame('cd', $finder->find('cd'));`
`171`		`- $this->assertSame('move', $finder->find('MoVe'));`
	`169`	`+ $this->assertSame('rmdir', strtolower($finder->find('RMDIR')));`
	`170`	`+ $this->assertSame('cd', strtolower($finder->find('cd')));`
	`171`	`+ $this->assertSame('move', strtolower($finder->find('MoVe')));`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`private function assertSamePath($expected, $tested)`