[Console] Provide a bugfix where an array could be passed

Amrouche Hamza · Amrouche Hamza · commit f4066a6afffb · 2017-12-12T15:00:15.000+01:00
diff --git a/src/Symfony/Component/Console/Helper/Table.php b/src/Symfony/Component/Console/Helper/Table.php
@@ -454,11 +454,16 @@ private function buildTableRows($rows)
      * @param int   $line
      *
      * @return array
+     *
+     * @throws \UnexpectedValueException
      */
     private function fillNextRows(array $rows, $line)
     {
         $unmergedRows = array();
         foreach ($rows[$line] as $column => $cell) {
+            if (!is_string($cell) && !$cell instanceof TableCell) {
+                throw new \UnexpectedValueException('The cell should always be a string, array given.');
+            }
             if ($cell instanceof TableCell && $cell->getRowspan() > 1) {
                 $nbLines = $cell->getRowspan() - 1;
                 $lines = array($cell);
diff --git a/src/Symfony/Component/Console/Tests/Helper/TableTest.php b/src/Symfony/Component/Console/Tests/Helper/TableTest.php
@@ -552,7 +552,7 @@ public function testRenderMultiByte()
         $table = new Table($output = $this->getOutputStream());
         $table
             ->setHeaders(array('■■'))
-            ->setRows(array(array(1234)))
+            ->setRows(array(array(new TableCell(1234))))
             ->setStyle('default')
         ;
         $table->render();
@@ -726,6 +726,22 @@ public function testColumnStyle()
         $this->assertEquals($expected, $this->getOutputContent($output));
     }
 
+    /**
+     * @expectedException \UnexpectedValueException
+     * @expectedExceptionMessage The cell should always be a string, array given.
+     */
+    public function testThrows()
+    {
+        $table = new Table($output = $this->getOutputStream());
+        $table
+            ->setHeaders(array('ISBN', 'Title', 'Author', 'Price'))
+            ->setRows(array(
+                array('99921-58-10-7', array(), 'Dante Alighieri', '9.95'),
+            ));
+
+        $table->render();
+    }
+
     public function testColumnWith()
     {
         $table = new Table($output = $this->getOutputStream());
