Move out click handling code to central place

Alexander Obuhovich · Alexander Obuhovich · commit ecc30cc87ccd · 2015-02-10T14:01:04.000+02:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig
@@ -281,24 +281,8 @@
                     }
 
                     // attach listener for expanding/collapsing the target
-                    Sfjs.addEventListener(buttons[i], 'click', function (e) {
-                        if (!e) {
-                            e = window.event;
-                        }
-
-                        if (e.target) {
-                            target = e.target;
-                        }
-                        else if (e.srcElement) {
-                            target = e.srcElement;
-                        }
-
-                        toggle(target);
-
-                        e.preventDefault ? e.preventDefault() : e.returnValue = false;
-                        e.stopPropagation();
-
-                        return false;
+                    clickHandler(buttons[i], function () {
+                        toggle(this);
                     });
 
                     if (states.hasOwnProperty(targetId)) {
@@ -391,26 +375,8 @@
                         throw "Tab target " + targetId + " does not exist";
                     }
 
-                    Sfjs.addEventListener(tabs[i], 'click', function (e) {
-                        var target;
-
-                        if (!e) {
-                            e = window.event;
-                        }
-
-                        if (e.target) {
-                            target = e.target;
-                        }
-                        else if (e.srcElement) {
-                            target = e.srcElement;
-                        }
-
-                        select(target);
-
-                        e.preventDefault ? e.preventDefault() : e.returnValue = false;
-                        e.stopPropagation();
-
-                        return false;
+                    clickHandler(buttons[i], function () {
+                        select(this);
                     });
 
                     Sfjs.addClass(target, 'hidden');
@@ -429,7 +395,35 @@
     }
 
     var tabTarget = new TabView(),
-        toggler = new Toggler(new JsonStorage(sessionStorage));
+        toggler = new Toggler(new JsonStorage(sessionStorage)),
+        clickHandler = function (element, callback) {
+            Sfjs.addEventListener(element, 'click', function (e) {
+                var target;
+
+                if (!e) {
+                    e = window.event;
+                }
+
+                if (e.target) {
+                    target = e.target;
+                }
+                else if (e.srcElement) {
+                    target = e.srcElement;
+                }
+
+                callback.call(target);
+
+                if (e.preventDefault) {
+                    e.preventDefault();
+                } else {
+                    e.returnValue = false;
+                }
+
+                e.stopPropagation();
+
+                return false;
+            });
+        };
 
     tabTarget.initTabs(document.querySelectorAll('.tree .tree-inner'));
     toggler.initButtons(document.querySelectorAll('a.toggle-button'));
