[Cache] Redis Tag Aware warn on wrong eviction policy

andrerom · nicolas-grekas · commit e77f6de1e860 · 2019-11-16T09:53:52.000+01:00
diff --git a/src/Symfony/Component/Cache/Adapter/RedisTagAwareAdapter.php b/src/Symfony/Component/Cache/Adapter/RedisTagAwareAdapter.php
@@ -14,6 +14,7 @@
 use Predis\Connection\Aggregate\ClusterInterface;
 use Predis\Connection\Aggregate\PredisCluster;
 use Predis\Response\Status;
+use Symfony\Component\Cache\CacheItem;
 use Symfony\Component\Cache\Exception\InvalidArgumentException;
 use Symfony\Component\Cache\Marshaller\DeflateMarshaller;
 use Symfony\Component\Cache\Marshaller\MarshallerInterface;
@@ -58,6 +59,11 @@ class RedisTagAwareAdapter extends AbstractTagAwareAdapter
      */
     private const DEFAULT_CACHE_TTL = 8640000;
 
+    /**
+     * @var string|null detected eviction policy used on Redis server
+     */
+    private $redisEvictionPolicy;
+
     /**
      * @param \Redis|\RedisArray|\RedisCluster|\Predis\ClientInterface $redisClient     The redis client
      * @param string                                                   $namespace       The default namespace
@@ -87,6 +93,13 @@ public function __construct($redisClient, string $namespace = '', int $defaultLi
      */
     protected function doSave(array $values, ?int $lifetime, array $addTagData = [], array $delTagData = []): array
     {
+        $eviction = $this->getRedisEvictionPolicy();
+        if ('noeviction' !== $eviction && 0 !== strpos($eviction, 'volatile-')) {
+            CacheItem::log($this->logger, sprintf('Redis maxmemory-policy setting "%s" is *not* supported by RedisTagAwareAdapter, use "noeviction" or  "volatile-*" eviction policies', $eviction));
+
+            return false;
+        }
+
         // serialize values
         if (!$serialized = $this->marshaller->marshall($values, $failed)) {
             return $failed;
@@ -260,4 +273,20 @@ private function renameKeys($redis, array $ids): array
 
         return $newIds;
     }
+
+    private function getRedisEvictionPolicy(): string
+    {
+        if (null !== $this->redisEvictionPolicy) {
+            return $this->redisEvictionPolicy;
+        }
+
+        foreach ($this->getHosts() as $host) {
+            $info = $host->info('Memory');
+            $info = isset($info['Memory']) ? $info['Memory'] : $info;
+
+            return $this->redisEvictionPolicy = $info['maxmemory_policy'];
+        }
+
+        return $this->redisEvictionPolicy = '';
+    }
 }
