minor #20464 [Workflow] Set the marking then announce enabled transition (lyrixx)

lyrixx · lyrixx · commit e493a1bca99d · 2016-11-10T10:17:19.000+01:00
This PR was merged into the 3.2-dev branch. Discussion ---------- [Workflow] Set the marking then announce enabled transition | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - It allows to auto-apply some transition from a listener. If we don't do that, the marking is not updated in the listener yet, so the transition is not really enabled. The feature was asked on [twitter](https://twitter.com/gaetanbuellet/status/796387741420441600) And It has been implemented (userland) [here](lyrixx/SFLive-Paris2016-Workflow@9fda92a) Commits ------- 51dad72 [Workflow] Set the marking then announce enabled transition
diff --git a/src/Symfony/Component/Workflow/Workflow.php b/src/Symfony/Component/Workflow/Workflow.php
@@ -126,10 +126,10 @@ public function apply($subject, $transitionName)
 
         $this->enter($subject, $transition, $marking);
 
-        $this->announce($subject, $transition, $marking);
-
         $this->markingStore->setMarking($subject, $marking);
 
+        $this->announce($subject, $transition, $marking);
+
         return $marking;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -126,10 +126,10 @@ public function apply($subject, $transitionName)`
`126`	`126`
`127`	`127`	`$this->enter($subject, $transition, $marking);`
`128`	`128`
`129`		`- $this->announce($subject, $transition, $marking);`
`130`		`-`
`131`	`129`	`$this->markingStore->setMarking($subject, $marking);`
`132`	`130`
	`131`	`+ $this->announce($subject, $transition, $marking);`
	`132`	`+`
`133`	`133`	`return $marking;`
`134`	`134`	`}`
`135`	`135`