do not overwrite variable value

xabbuh · xabbuh · commit e379dbbf219b · 2019-12-27T10:03:19.000+01:00
diff --git a/src/Symfony/Component/Cache/DependencyInjection/CachePoolPass.php b/src/Symfony/Component/Cache/DependencyInjection/CachePoolPass.php
@@ -54,7 +54,7 @@ public function process(ContainerBuilder $container)
         }
         $seed .= '.'.$container->getParameter('kernel.container_class');
 
-        $pools = [];
+        $allPools = [];
         $clearers = [];
         $attributes = [
             'provider',
@@ -119,15 +119,15 @@ public function process(ContainerBuilder $container)
                 $clearers[$clearer][$name] = new Reference($id, $container::IGNORE_ON_UNINITIALIZED_REFERENCE);
             }
 
-            $pools[$name] = new Reference($id, $container::IGNORE_ON_UNINITIALIZED_REFERENCE);
+            $allPools[$name] = new Reference($id, $container::IGNORE_ON_UNINITIALIZED_REFERENCE);
         }
 
         $notAliasedCacheClearerId = $this->cacheClearerId;
         while ($container->hasAlias($this->cacheClearerId)) {
             $this->cacheClearerId = (string) $container->getAlias($this->cacheClearerId);
         }
         if ($container->hasDefinition($this->cacheClearerId)) {
-            $clearers[$notAliasedCacheClearerId] = $pools;
+            $clearers[$notAliasedCacheClearerId] = $allPools;
         }
 
         foreach ($clearers as $id => $pools) {
@@ -145,7 +145,7 @@ public function process(ContainerBuilder $container)
         }
 
         if ($container->hasDefinition('console.command.cache_pool_list')) {
-            $container->getDefinition('console.command.cache_pool_list')->replaceArgument(0, array_keys($pools));
+            $container->getDefinition('console.command.cache_pool_list')->replaceArgument(0, array_keys($allPools));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function process(ContainerBuilder $container)`
`54`	`54`	`}`
`55`	`55`	`$seed .= '.'.$container->getParameter('kernel.container_class');`
`56`	`56`
`57`		`- $pools = [];`
	`57`	`+ $allPools = [];`
`58`	`58`	`$clearers = [];`
`59`	`59`	`$attributes = [`
`60`	`60`	`'provider',`
`@@ -119,15 +119,15 @@ public function process(ContainerBuilder $container)`
`119`	`119`	`$clearers[$clearer][$name] = new Reference($id, $container::IGNORE_ON_UNINITIALIZED_REFERENCE);`
`120`	`120`	`}`
`121`	`121`
`122`		`- $pools[$name] = new Reference($id, $container::IGNORE_ON_UNINITIALIZED_REFERENCE);`
	`122`	`+ $allPools[$name] = new Reference($id, $container::IGNORE_ON_UNINITIALIZED_REFERENCE);`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`$notAliasedCacheClearerId = $this->cacheClearerId;`
`126`	`126`	`while ($container->hasAlias($this->cacheClearerId)) {`
`127`	`127`	`$this->cacheClearerId = (string) $container->getAlias($this->cacheClearerId);`
`128`	`128`	`}`
`129`	`129`	`if ($container->hasDefinition($this->cacheClearerId)) {`
`130`		`- $clearers[$notAliasedCacheClearerId] = $pools;`
	`130`	`+ $clearers[$notAliasedCacheClearerId] = $allPools;`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`foreach ($clearers as $id => $pools) {`
`@@ -145,7 +145,7 @@ public function process(ContainerBuilder $container)`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`if ($container->hasDefinition('console.command.cache_pool_list')) {`
`148`		`- $container->getDefinition('console.command.cache_pool_list')->replaceArgument(0, array_keys($pools));`
	`148`	`+ $container->getDefinition('console.command.cache_pool_list')->replaceArgument(0, array_keys($allPools));`
`149`	`149`	`}`
`150`	`150`	`}`
`151`	`151`