bug #36936 [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8 (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit e3069df98fa6 · 2020-05-24T11:40:24.000+02:00
This PR was merged into the 5.1 branch. Discussion ---------- [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8 | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In PHP 8, abstract methods on traits are now enforcing that their using classes match the signature. But this is not the semantics we need in this trait: we want to allow ppl to use a different type of configurators, to provide extensibility of the DSL each provide. This makes nightly job fail with fatal error currently. There is no other options here. /cc @nikic FYI Commits ------- 4473f45 [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8
diff --git a/src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php b/src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php
@@ -39,7 +39,7 @@ trait MicroKernelTrait
      *         ->controller('App\Controller\AdminController::dashboard')
      *     ;
      */
-    abstract protected function configureRoutes(RoutingConfigurator $routes);
+    //abstract protected function configureRoutes(RoutingConfigurator $routes);
 
     /**
      * Configures the container.
@@ -58,7 +58,7 @@ abstract protected function configureRoutes(RoutingConfigurator $routes);
      *
      *     $c->parameters()->set('halloween', 'lot of fun');
      */
-    abstract protected function configureContainer(ContainerConfigurator $c);
+    //abstract protected function configureContainer(ContainerConfigurator $c);
 
     /**
      * {@inheritdoc}
