[Console] Use console exception for missing input

chalasr · chalasr · commit dd49822ebfe5 · 2016-11-01T20:04:36.000+01:00
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -149,7 +149,7 @@ private function doAsk(OutputInterface $output, Question $question)
             if (false === $ret) {
                 $ret = fgets($inputStream, 4096);
                 if (false === $ret) {
-                    throw new \RuntimeException('Aborted');
+                    throw new RuntimeException('Aborted');
                 }
                 $ret = trim($ret);
             }
diff --git a/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php b/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
@@ -393,6 +393,17 @@ public function testChoiceOutputFormattingQuestionForUtf8Keys()
         $dialog->ask($this->createStreamableInputInterfaceMock($this->getInputStream("\n")), $output, $question);
     }
 
+    /**
+     * @expectedException        \Symfony\Component\Console\Exception\RuntimeException
+     * @expectedExceptionMessage Aborted
+     */
+    public function testAskThrowsExceptionOnMissingInput()
+    {
+        $dialog = new QuestionHelper();
+
+        $dialog->ask($this->createStreamableInputInterfaceMock($this->getInputStream('')), $this->createOutputInterface(), new Question('What\'s your name?'));
+    }
+
     /**
      * @group legacy
      */

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ private function doAsk(OutputInterface $output, Question $question)`
`149`	`149`	`if (false === $ret) {`
`150`	`150`	`$ret = fgets($inputStream, 4096);`
`151`	`151`	`if (false === $ret) {`
`152`		`- throw new \RuntimeException('Aborted');`
	`152`	`+ throw new RuntimeException('Aborted');`
`153`	`153`	`}`
`154`	`154`	`$ret = trim($ret);`
`155`	`155`	`}`