[Serializer] [ObjectNormalizer] Use \is_string

Maximilian Zumbansen · Maximilian Zumbansen · commit d2a2cbdcfa0e · 2024-06-26T15:46:24.000+02:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -566,7 +566,7 @@ private function validateAndDenormalizeLegacy(array $types, string $currentClass
                     return (float) $data;
                 }
 
-                if (LegacyType::BUILTIN_TYPE_BOOL === $builtinType && is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {
+                if (LegacyType::BUILTIN_TYPE_BOOL === $builtinType && \is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {
                     return filter_var($data, \FILTER_VALIDATE_BOOL, \FILTER_NULL_ON_FAILURE);
                 }
 
@@ -791,7 +791,7 @@ private function validateAndDenormalize(Type $type, string $currentClass, string
                     return (float) $data;
                 }
 
-                if (TypeIdentifier::BOOL === $typeIdentifier && is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {
+                if (TypeIdentifier::BOOL === $typeIdentifier && \is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {
                     return filter_var($data, \FILTER_VALIDATE_BOOL, \FILTER_NULL_ON_FAILURE);
                 }
 
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php
@@ -1205,7 +1205,7 @@ public function testDenormalizeBooleanTypeWithFilterBool(array $data, ?bool $exp
 
         $dummy = $normalizer->denormalize($data, BoolPropertyDummy::class, null, [AbstractNormalizer::FILTER_BOOL => true]);
 
-        self::assertSame($expectedFoo, $dummy->foo);
+        $this->assertSame($expectedFoo, $dummy->foo);
     }
 
     public function provideDenormalizeWithFilterBoolData()

Original file line number	Diff line number	Diff line change
`@@ -566,7 +566,7 @@ private function validateAndDenormalizeLegacy(array $types, string $currentClass`
`566`	`566`	`return (float) $data;`
`567`	`567`	`}`
`568`	`568`
`569`		`- if (LegacyType::BUILTIN_TYPE_BOOL === $builtinType && is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {`
	`569`	`+ if (LegacyType::BUILTIN_TYPE_BOOL === $builtinType && \is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {`
`570`	`570`	`return filter_var($data, \FILTER_VALIDATE_BOOL, \FILTER_NULL_ON_FAILURE);`
`571`	`571`	`}`
`572`	`572`
`@@ -791,7 +791,7 @@ private function validateAndDenormalize(Type $type, string $currentClass, string`
`791`	`791`	`return (float) $data;`
`792`	`792`	`}`
`793`	`793`
`794`		`- if (TypeIdentifier::BOOL === $typeIdentifier && is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {`
	`794`	`+ if (TypeIdentifier::BOOL === $typeIdentifier && \is_string($data) && ($context[self::FILTER_BOOL] ?? false)) {`
`795`	`795`	`return filter_var($data, \FILTER_VALIDATE_BOOL, \FILTER_NULL_ON_FAILURE);`
`796`	`796`	`}`
`797`	`797`
Original file line number	Diff line number	Diff line change
`@@ -1205,7 +1205,7 @@ public function testDenormalizeBooleanTypeWithFilterBool(array $data, ?bool $exp`
`1205`	`1205`
`1206`	`1206`	`$dummy = $normalizer->denormalize($data, BoolPropertyDummy::class, null, [AbstractNormalizer::FILTER_BOOL => true]);`
`1207`	`1207`
`1208`		`- self::assertSame($expectedFoo, $dummy->foo);`
	`1208`	`+ $this->assertSame($expectedFoo, $dummy->foo);`
`1209`	`1209`	`}`
`1210`	`1210`
`1211`	`1211`	`public function provideDenormalizeWithFilterBoolData()`