minor #11463 [Validator] prevent unnecessary calls inside ExecutionContext (Tobion)

webmozart · webmozart · commit cd29962dc010 · 2014-07-28T16:51:00.000+02:00
This PR was merged into the 2.5 branch. Discussion ---------- [Validator] prevent unnecessary calls inside ExecutionContext | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT Small performance improvement by preventing calls to `PropertyPath::append($this->propertyPath, $subPath)` when not needed. Commits ------- d6d462a [Validator] do not call getter inside ExecutionContext to prevent unnecessary calls
diff --git a/src/Symfony/Component/Validator/Context/ExecutionContext.php b/src/Symfony/Component/Validator/Context/ExecutionContext.php
@@ -183,8 +183,8 @@ public function addViolation($message, array $parameters = array(), $invalidValu
             $message,
             $parameters,
             $this->root,
-            $this->getPropertyPath(),
-            $this->getValue(),
+            $this->propertyPath,
+            $this->value,
             null,
             null
         ));
@@ -200,8 +200,8 @@ public function buildViolation($message, array $parameters = array())
             $message,
             $parameters,
             $this->root,
-            $this->getPropertyPath(),
-            $this->getValue(),
+            $this->propertyPath,
+            $this->value,
             $this->translator,
             $this->translationDomain
         );
