minor #32620 [Process] remove deprecated inheritEnvironmentVariables() method (xabbuh)

fabpot · fabpot · commit cade80889b74 · 2019-07-19T11:17:57.000+02:00
This PR was merged into the 5.0-dev branch. Discussion ---------- [Process] remove deprecated inheritEnvironmentVariables() method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- fa4bade remove deprecated inheritEnvironmentVariables() method
diff --git a/src/Symfony/Component/Process/CHANGELOG.md b/src/Symfony/Component/Process/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 5.0.0
 -----
 
+ * removed `Process::inheritEnvironmentVariables()`
  * removed `PhpProcess::setPhpBinary()`
  * `Process` must be instantiated with a command array, use `Process::fromShellCommandline()` when the command should be parsed by the shell
  * removed `Process::setCommandLine()`
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -1176,24 +1176,6 @@ public function setInput($input)
         return $this;
     }
 
-    /**
-     * Sets whether environment variables will be inherited or not.
-     *
-     * @return self The current Process instance
-     *
-     * @deprecated since Symfony 4.4, env variables are always inherited
-     */
-    public function inheritEnvironmentVariables(bool $inheritEnv = true)
-    {
-        @trigger_error(sprintf('The "%s()" method is deprecated since Symfony 4.4, env variables are always inherited.', __METHOD__), E_USER_DEPRECATED);
-
-        if (!$inheritEnv) {
-            throw new InvalidArgumentException('Not inheriting environment variables is not supported.');
-        }
-
-        return $this;
-    }
-
     /**
      * Performs a check between the timeout definition and the time the process started.
      *
