Use DSN for lock configuration too

jderusse · jderusse · commit b0c2ee354988 · 2017-09-28T12:06:08.000+02:00
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -1,6 +1,13 @@
 UPGRADE FROM 3.x to 4.0
 =======================
 
+Cache
+-----
+
+ * The `AbstractAdapter::createConnection()`, `RedisTrait::createConnection()` 
+   and `MemcachedTrait::createConnection()` methods have been removed. Use the
+   Dsn component instead.
+ 
 ClassLoader
 -----------
 
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/CachePoolPass.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/CachePoolPass.php
@@ -17,6 +17,7 @@
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\DependencyInjection\Exception\LogicException;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Exception\InvalidArgumentException;
 use Symfony\Component\Dsn\ConnectionFactory;
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -43,6 +43,7 @@
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\ServiceSubscriberInterface;
+use Symfony\Component\Dsn\ConnectionFactory;
 use Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
@@ -1706,7 +1707,7 @@ private function registerLockConfiguration(array $config, ContainerBuilder $cont
                         if (!$container->hasDefinition($connectionDefinitionId = $container->hash($storeDsn))) {
                             $connectionDefinition = new Definition(\stdClass::class);
                             $connectionDefinition->setPublic(false);
-                            $connectionDefinition->setFactory(array(StoreFactory::class, 'createConnection'));
+                            $connectionDefinition->setFactory(array(ConnectionFactory::class, 'createConnection'));
                             $connectionDefinition->setArguments(array($storeDsn));
                             $container->setDefinition($connectionDefinitionId, $connectionDefinition);
                         }
diff --git a/src/Symfony/Bundle/FrameworkBundle/composer.json b/src/Symfony/Bundle/FrameworkBundle/composer.json
@@ -37,6 +37,7 @@
         "symfony/browser-kit": "~2.8|~3.0|~4.0",
         "symfony/console": "~3.4|~4.0",
         "symfony/css-selector": "~2.8|~3.0|~4.0",
+        "symfony/dsn": "~3.4",
         "symfony/dom-crawler": "~2.8|~3.0|~4.0",
         "symfony/polyfill-intl-icu": "~1.0",
         "symfony/security": "~2.8|~3.0|~4.0",
diff --git a/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php b/src/Symfony/Component/Cache/Adapter/AbstractAdapter.php
@@ -21,8 +21,8 @@
 use Symfony\Component\Cache\Traits\AbstractTrait;
 use Symfony\Component\Dsn\ConnectionFactory;
 use Symfony\Component\Dsn\Exception\InvalidArgumentException as DsnInvalidArgumentException;
-use Symfony\Component\Dsn\Factory\MemcachedConnectionFactory;
-use Symfony\Component\Dsn\Factory\RedisConnectionFactory;
+use Symfony\Component\Dsn\Factory\MemcachedFactory;
+use Symfony\Component\Dsn\Factory\RedisFactory;
 
 /**
  * @author Nicolas Grekas <p@tchwork.com>
@@ -132,7 +132,7 @@ public static function createSystemCache($namespace, $defaultLifetime, $version,
 
     public static function createConnection($dsn, array $options = array())
     {
-        @trigger_error(sprintf('The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the DsnFactory::createConnection() method from Dsn component instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the ConnectionFactory::create() method from Dsn component instead.', __METHOD__), E_USER_DEPRECATED);
 
         try {
             $type = ConnectionFactory::getType($dsn);
@@ -142,9 +142,9 @@ public static function createConnection($dsn, array $options = array())
 
         switch ($type) {
             case ConnectionFactory::TYPE_MEMCACHED:
-                return MemcachedConnectionFactory::createConnection($dsn, $options);
+                return MemcachedFactory::create($dsn, $options);
             case ConnectionFactory::TYPE_REDIS:
-                return RedisConnectionFactory::createConnection($dsn, $options);
+                return RedisFactory::create($dsn, $options);
         }
 
         throw new InvalidArgumentException(sprintf('Unsupported DSN: %s.', $dsn));
diff --git a/src/Symfony/Component/Cache/Adapter/MemcachedAdapter.php b/src/Symfony/Component/Cache/Adapter/MemcachedAdapter.php
@@ -25,7 +25,7 @@ class MemcachedAdapter extends AbstractAdapter
      * Using a MemcachedAdapter with a TagAwareAdapter for storing tags is discouraged.
      * Using a RedisAdapter is recommended instead. If you cannot do otherwise, be aware that:
      * - the Memcached::OPT_BINARY_PROTOCOL must be enabled
-     *   (that's the default when using MemcachedAdapter::createConnection());
+     *   (that's the default when using MemcachedFactory::create());
      * - tags eviction by Memcached's LRU algorithm will break by-tags invalidation;
      *   your Memcached memory should be large enough to never trigger LRU.
      *
diff --git a/src/Symfony/Component/Cache/CHANGELOG.md b/src/Symfony/Component/Cache/CHANGELOG.md
@@ -9,6 +9,8 @@ CHANGELOG
  * added prune logic to FilesystemTrait, PhpFilesTrait, PdoTrait, TagAwareAdapter and ChainTrait
  * now FilesystemAdapter, PhpFilesAdapter, FilesystemCache, PhpFilesCache, PdoAdapter, PdoCache, ChainAdapter, and
    ChainCache implement PruneableInterface and support manual stale cache pruning
+ * deprecated `AbstractAdapter::createConnection()`, `RedisTrait::createConnection()` and 
+   `MemcachedTrait::createConnection()` 
 
 3.3.0
 -----
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Cache\Tests\Adapter;
 
 use Symfony\Component\Cache\Adapter\MemcachedAdapter;
+use Symfony\Component\Dsn\Factory\MemcachedFactory;
 
 class MemcachedAdapterTest extends AdapterTestCase
 {
@@ -27,7 +28,7 @@ public static function setupBeforeClass()
         if (!MemcachedAdapter::isSupported()) {
             self::markTestSkipped('Extension memcached >=2.2.0 required.');
         }
-        self::$client = MemcachedConnectionFactory::createConnection('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false));
+        self::$client = MemcachedFactory::create('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false));
         self::$client->get('foo');
         $code = self::$client->getResultCode();
 
@@ -38,14 +39,14 @@ public static function setupBeforeClass()
 
     public function createCachePool($defaultLifetime = 0)
     {
-        $client = $defaultLifetime ? MemcachedConnectionFactory::createConnection('memcached://'.getenv('MEMCACHED_HOST')) : self::$client;
+        $client = $defaultLifetime ? MemcachedFactory::create('memcached://'.getenv('MEMCACHED_HOST')) : self::$client;
 
         return new MemcachedAdapter($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
     }
 
     /**
      * @group legacy
-     * @expectedDeprecation This "%s" method is deprecated.
+     * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the MemcachedFactory::create() method from Dsn component instead.
      */
     public function testCreateConnectionDeprecated()
     {
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PredisAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PredisAdapterTest.php
@@ -24,13 +24,11 @@ public static function setupBeforeClass()
 
     /**
      * @group legacy
-     * @expectedDeprecation This "%s" method is deprecated.
+     * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisFactory::create() method from Dsn component instead.
      */
     public function testCreateConnectionDeprecated()
     {
-        $client = RedisAdapter::createConnection('redis://'.getenv('REDIS_HOST'));
-
-        $this->assertInstanceOf(\Predis\Client, $client);
+        RedisAdapter::createConnection('redis://'.getenv('REDIS_HOST'));
     }
 
     /**
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php
@@ -13,18 +13,19 @@
 
 use Symfony\Component\Cache\Adapter\AbstractAdapter;
 use Symfony\Component\Cache\Adapter\RedisAdapter;
+use Symfony\Component\Dsn\Factory\RedisFactory;
 
 class RedisAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setupBeforeClass()
     {
         parent::setupBeforeClass();
-        self::$redis = AbstractAdapter::createConnection('redis://'.getenv('REDIS_HOST'));
+        self::$redis = RedisFactory::create('redis://'.getenv('REDIS_HOST'));
     }
 
     /**
      * @group legacy
-     * @expectedDeprecation This "%s" method is deprecated.
+     * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisFactory::create() method from Dsn component instead.
      */
     public function testCreateConnectionDeprecated()
     {
diff --git a/src/Symfony/Component/Cache/Tests/Simple/MemcachedCacheTest.php b/src/Symfony/Component/Cache/Tests/Simple/MemcachedCacheTest.php
@@ -12,7 +12,7 @@
 namespace Symfony\Component\Cache\Tests\Simple;
 
 use Symfony\Component\Cache\Simple\MemcachedCache;
-use Symfony\Component\Dsn\Factory\MemcachedConnectionFactory;
+use Symfony\Component\Dsn\Factory\MemcachedFactory;
 
 class MemcachedCacheTest extends CacheTestCase
 {
@@ -29,7 +29,7 @@ public static function setupBeforeClass()
         if (!MemcachedCache::isSupported()) {
             self::markTestSkipped('Extension memcached >=2.2.0 required.');
         }
-        self::$client = MemcachedConnectionFactory::createConnection('memcached://'.getenv('MEMCACHED_HOST'));
+        self::$client = MemcachedFactory::create('memcached://'.getenv('MEMCACHED_HOST'));
         self::$client->get('foo');
         $code = self::$client->getResultCode();
 
@@ -40,7 +40,7 @@ public static function setupBeforeClass()
 
     public function createSimpleCache($defaultLifetime = 0)
     {
-        $client = $defaultLifetime ? MemcachedConnectionFactory::createConnection('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false)) : self::$client;
+        $client = $defaultLifetime ? MemcachedFactory::create('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false)) : self::$client;
 
         return new MemcachedCache($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
     }
diff --git a/src/Symfony/Component/Cache/Tests/Simple/RedisCacheTest.php b/src/Symfony/Component/Cache/Tests/Simple/RedisCacheTest.php
@@ -12,24 +12,23 @@
 namespace Symfony\Component\Cache\Tests\Simple;
 
 use Symfony\Component\Cache\Simple\RedisCache;
+use Symfony\Component\Dsn\Factory\RedisFactory;
 
 class RedisCacheTest extends AbstractRedisCacheTest
 {
     public static function setupBeforeClass()
     {
         parent::setupBeforeClass();
-        self::$redis = RedisCache::createConnection('redis://'.getenv('REDIS_HOST'));
+        self::$redis = RedisFactory::create('redis://'.getenv('REDIS_HOST'));
     }
 
     /**
      * @group legacy
-     * @expectedDeprecation This "%s" method is deprecated.
+     * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisFactory::create() method from Dsn component instead.
      */
     public function testCreateConnectionDeprecated()
     {
-        $client = RedisCache::createConnection('redis://'.getenv('REDIS_HOST'));
-
-        $this->assertInstanceOf(\Predis\Client, $client);
+        RedisCache::createConnection('redis://'.getenv('REDIS_HOST'));
     }
 
     /**
diff --git a/src/Symfony/Component/Cache/Traits/MemcachedTrait.php b/src/Symfony/Component/Cache/Traits/MemcachedTrait.php
@@ -13,7 +13,7 @@
 
 use Symfony\Component\Cache\Exception\CacheException;
 use Symfony\Component\Cache\Exception\InvalidArgumentException;
-use Symfony\Component\Dsn\Factory\MemcachedConnectionFactory;
+use Symfony\Component\Dsn\Factory\MemcachedFactory;
 
 /**
  * @author Rob Frawley 2nd <rmf@src.run>
@@ -52,15 +52,15 @@ private function init(\Memcached $client, $namespace, $defaultLifetime)
     }
 
     /**
-     * @see MemcachedConnectionFactory::createConnection()
+     * @see MemcachedFactory::create()
      */
     public static function createConnection($servers, array $options = array())
     {
-        @trigger_error(sprintf('The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the MemcachedDsnFactory::createConnection() method from Dsn component instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the MemcachedFactory::create() method from Dsn component instead.', __METHOD__), E_USER_DEPRECATED);
 
         foreach ((array) $servers as $i => $dsn) {
             if (is_array($dsn)) {
-                @trigger_error(sprintf('Passing an array of array to the %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the MemcachedDsnFactory::createConnection() method from Dsn component instead with an array of Dsn instead.', __METHOD__), E_USER_DEPRECATED);
+                @trigger_error(sprintf('Passing an array of array to the %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the MemcachedFactory::create() method from Dsn component instead with an array of Dsn instead.', __METHOD__), E_USER_DEPRECATED);
 
                 $scheme = 'memcached://';
                 $host = isset($dsn['host']) ? $dsn['host'] : '';
@@ -81,16 +81,12 @@ public static function createConnection($servers, array $options = array())
         }
 
         try {
-            return MemcachedConnectionFactory::createConnection($servers, $options);
+            return MemcachedFactory::create($servers, $options);
         } catch (\Symfony\Component\Dsn\Exception\InvalidArgumentException $e) {
             throw new InvalidArgumentException($e->getMessage(), 0, $e);
         }
     }
 
-    private static function buildDsn($parsedDsn)
-    {
-    }
-
     /**
      * {@inheritdoc}
      */
diff --git a/src/Symfony/Component/Cache/Traits/RedisTrait.php b/src/Symfony/Component/Cache/Traits/RedisTrait.php
@@ -16,7 +16,7 @@
 use Predis\Connection\Aggregate\RedisCluster;
 use Predis\Response\Status;
 use Symfony\Component\Cache\Exception\InvalidArgumentException;
-use Symfony\Component\Dsn\Factory\RedisConnectionFactory;
+use Symfony\Component\Dsn\Factory\RedisFactory;
 
 /**
  * @author Aurimas Niekis <aurimas@niekis.lt>
@@ -47,14 +47,14 @@ public function init($redisClient, $namespace = '', $defaultLifetime = 0)
     }
 
     /**
-     * @see RedisConnectionFactory::createConnection()
+     * @see RedisFactory::create()
      */
     public static function createConnection($dsn, array $options = array())
     {
-        @trigger_error(sprintf('The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisDsnFactory::createConnection() method from Dsn component instead.', __METHOD__), E_USER_DEPRECATED);
+        @trigger_error(sprintf('The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisFactory::create() method from Dsn component instead.', __METHOD__), E_USER_DEPRECATED);
 
         try {
-            return RedisConnectionFactory::createConnection($dsn, $options);
+            return RedisFactory::create($dsn, $options);
         } catch (\Symfony\Component\Dsn\Exception\InvalidArgumentException $e) {
             throw new InvalidArgumentException($e->getMessage(), 0, $e);
         }
diff --git a/src/Symfony/Component/Cache/composer.json b/src/Symfony/Component/Cache/composer.json
@@ -33,6 +33,9 @@
         "predis/predis": "~1.0",
         "symfony/dsn": "3.4"
     },
+    "suggest": {
+        "symfony/dsn": "For configuring redis and memcached adapters with Dsn"
+    },
     "conflict": {
         "symfony/var-dumper": "<3.3"
     },
diff --git a/src/Symfony/Component/Dsn/Factory/RedisFactory.php b/src/Symfony/Component/Dsn/Factory/RedisFactory.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Dsn\Factory;
 
+use Predis\Connection\Factory;
 use Symfony\Component\Dsn\Exception\InvalidArgumentException;
 
 /**
diff --git a/src/Symfony/Component/Dsn/README.md b/src/Symfony/Component/Dsn/README.md
@@ -1,7 +1,8 @@
 Dsn Component
 =============
 
-Provides utilities for handle Data Source Names.
+Provides utilities for creating connections using DSN (Data Source Names) 
+strings.
 
 Resources
 ---------
diff --git a/src/Symfony/Component/Lock/Store/MemcachedStore.php b/src/Symfony/Component/Lock/Store/MemcachedStore.php
diff --git a/src/Symfony/Component/Lock/Store/RedisStore.php b/src/Symfony/Component/Lock/Store/RedisStore.php
diff --git a/src/Symfony/Component/Lock/Store/StoreFactory.php b/src/Symfony/Component/Lock/Store/StoreFactory.php
diff --git a/src/Symfony/Component/Lock/Tests/Store/MemcachedStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/MemcachedStoreTest.php
diff --git a/src/Symfony/Component/Lock/composer.json b/src/Symfony/Component/Lock/composer.json

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class MemcachedAdapter extends AbstractAdapter`
`25`	`25`	`* Using a MemcachedAdapter with a TagAwareAdapter for storing tags is discouraged.`
`26`	`26`	`* Using a RedisAdapter is recommended instead. If you cannot do otherwise, be aware that:`
`27`	`27`	`* - the Memcached::OPT_BINARY_PROTOCOL must be enabled`
`28`		`- * (that's the default when using MemcachedAdapter::createConnection());`
	`28`	`+ * (that's the default when using MemcachedFactory::create());`
`29`	`29`	`* - tags eviction by Memcached's LRU algorithm will break by-tags invalidation;`
`30`	`30`	`* your Memcached memory should be large enough to never trigger LRU.`
`31`	`31`	`*`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespace Symfony\Component\Cache\Tests\Adapter;`
`13`	`13`
`14`	`14`	`use Symfony\Component\Cache\Adapter\MemcachedAdapter;`
	`15`	`+use Symfony\Component\Dsn\Factory\MemcachedFactory;`
`15`	`16`
`16`	`17`	`class MemcachedAdapterTest extends AdapterTestCase`
`17`	`18`	`{`
`@@ -27,7 +28,7 @@ public static function setupBeforeClass()`
`27`	`28`	`if (!MemcachedAdapter::isSupported()) {`
`28`	`29`	`self::markTestSkipped('Extension memcached >=2.2.0 required.');`
`29`	`30`	`}`
`30`		`- self::$client = MemcachedConnectionFactory::createConnection('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false));`
	`31`	`+ self::$client = MemcachedFactory::create('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false));`
`31`	`32`	`self::$client->get('foo');`
`32`	`33`	`$code = self::$client->getResultCode();`
`33`	`34`
`@@ -38,14 +39,14 @@ public static function setupBeforeClass()`
`38`	`39`
`39`	`40`	`public function createCachePool($defaultLifetime = 0)`
`40`	`41`	`{`
`41`		`- $client = $defaultLifetime ? MemcachedConnectionFactory::createConnection('memcached://'.getenv('MEMCACHED_HOST')) : self::$client;`
	`42`	`+ $client = $defaultLifetime ? MemcachedFactory::create('memcached://'.getenv('MEMCACHED_HOST')) : self::$client;`
`42`	`43`
`43`	`44`	`return new MemcachedAdapter($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`/**`
`47`	`48`	`* @group legacy`
`48`		`- * @expectedDeprecation This "%s" method is deprecated.`
	`49`	`+ * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the MemcachedFactory::create() method from Dsn component instead.`
`49`	`50`	`*/`
`50`	`51`	`public function testCreateConnectionDeprecated()`
`51`	`52`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,13 +24,11 @@ public static function setupBeforeClass()`
`24`	`24`
`25`	`25`	`/**`
`26`	`26`	`* @group legacy`
`27`		`- * @expectedDeprecation This "%s" method is deprecated.`
	`27`	`+ * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisFactory::create() method from Dsn component instead.`
`28`	`28`	`*/`
`29`	`29`	`public function testCreateConnectionDeprecated()`
`30`	`30`	`{`
`31`		`- $client = RedisAdapter::createConnection('redis://'.getenv('REDIS_HOST'));`
`32`		`-`
`33`		`- $this->assertInstanceOf(\Predis\Client, $client);`
	`31`	`+ RedisAdapter::createConnection('redis://'.getenv('REDIS_HOST'));`
`34`	`32`	`}`
`35`	`33`
`36`	`34`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -13,18 +13,19 @@`
`13`	`13`
`14`	`14`	`use Symfony\Component\Cache\Adapter\AbstractAdapter;`
`15`	`15`	`use Symfony\Component\Cache\Adapter\RedisAdapter;`
	`16`	`+use Symfony\Component\Dsn\Factory\RedisFactory;`
`16`	`17`
`17`	`18`	`class RedisAdapterTest extends AbstractRedisAdapterTest`
`18`	`19`	`{`
`19`	`20`	`public static function setupBeforeClass()`
`20`	`21`	`{`
`21`	`22`	`parent::setupBeforeClass();`
`22`		`- self::$redis = AbstractAdapter::createConnection('redis://'.getenv('REDIS_HOST'));`
	`23`	`+ self::$redis = RedisFactory::create('redis://'.getenv('REDIS_HOST'));`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`/**`
`26`	`27`	`* @group legacy`
`27`		`- * @expectedDeprecation This "%s" method is deprecated.`
	`28`	`+ * @expectedDeprecation The %s() method is deprecated since version 3.4 and will be removed in 4.0. Use the RedisFactory::create() method from Dsn component instead.`
`28`	`29`	`*/`
`29`	`30`	`public function testCreateConnectionDeprecated()`
`30`	`31`	`{`