-

fabpot · fabpot · commit b0bd22f55890 · 2023-01-08T12:18:41.000+01:00
diff --git a/src/Symfony/Component/Webhook/Client/AbstractRequestParser.php b/src/Symfony/Component/Webhook/Client/AbstractRequestParser.php
@@ -31,12 +31,12 @@ public function parse(Request $request, string $secret): ?RemoteEvent
         return $this->doParse($request, $secret);
     }
 
-    public function getSuccessfulResponse(): Response
+    public function createSuccessfulResponse(): Response
     {
         return new Response('', 202);
     }
 
-    public function getRejectedResponse(string $reason): Response
+    public function createRejectedResponse(string $reason): Response
     {
         return new Response($reason, 406);
     }
diff --git a/src/Symfony/Component/Webhook/Client/RequestParserInterface.php b/src/Symfony/Component/Webhook/Client/RequestParserInterface.php
@@ -32,7 +32,7 @@ interface RequestParserInterface
      */
     public function parse(Request $request, string $secret): ?RemoteEvent;
 
-    public function getSuccessfulResponse(): Response;
+    public function createSuccessfulResponse(): Response;
 
-    public function getRejectedResponse(string $reason): Response;
+    public function createRejectedResponse(string $reason): Response;
 }
diff --git a/src/Symfony/Component/Webhook/Controller/WebhookController.php b/src/Symfony/Component/Webhook/Controller/WebhookController.php
@@ -43,11 +43,11 @@ public function handle(string $type, Request $request, MessageBusInterface $bus)
         $parser = $this->parsers[$type]['parser'];
 
         if (!$event = $parser->parse($request, $this->parsers[$type]['secret'])) {
-            return $parser->getRejectedResponse('Unable to parse the webhook payload.');
+            return $parser->createRejectedResponse('Unable to parse the webhook payload.');
         }
 
         $bus->dispatch(new ConsumeRemoteEventMessage($type, $event));
 
-        return $parser->getSuccessfulResponse();
+        return $parser->createSuccessfulResponse();
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -31,12 +31,12 @@ public function parse(Request $request, string $secret): ?RemoteEvent`
`31`	`31`	`return $this->doParse($request, $secret);`
`32`	`32`	`}`
`33`	`33`
`34`		`- public function getSuccessfulResponse(): Response`
	`34`	`+ public function createSuccessfulResponse(): Response`
`35`	`35`	`{`
`36`	`36`	`return new Response('', 202);`
`37`	`37`	`}`
`38`	`38`
`39`		`- public function getRejectedResponse(string $reason): Response`
	`39`	`+ public function createRejectedResponse(string $reason): Response`
`40`	`40`	`{`
`41`	`41`	`return new Response($reason, 406);`
`42`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ interface RequestParserInterface`
`32`	`32`	`*/`
`33`	`33`	`public function parse(Request $request, string $secret): ?RemoteEvent;`
`34`	`34`
`35`		`- public function getSuccessfulResponse(): Response;`
	`35`	`+ public function createSuccessfulResponse(): Response;`
`36`	`36`
`37`		`- public function getRejectedResponse(string $reason): Response;`
	`37`	`+ public function createRejectedResponse(string $reason): Response;`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,11 @@ public function handle(string $type, Request $request, MessageBusInterface $bus)`
`43`	`43`	`$parser = $this->parsers[$type]['parser'];`
`44`	`44`
`45`	`45`	`if (!$event = $parser->parse($request, $this->parsers[$type]['secret'])) {`
`46`		`- return $parser->getRejectedResponse('Unable to parse the webhook payload.');`
	`46`	`+ return $parser->createRejectedResponse('Unable to parse the webhook payload.');`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`$bus->dispatch(new ConsumeRemoteEventMessage($type, $event));`
`50`	`50`
`51`		`- return $parser->getSuccessfulResponse();`
	`51`	`+ return $parser->createSuccessfulResponse();`
`52`	`52`	`}`
`53`	`53`	`}`