bug #46178 [DependencyInjection] Properly declare #[When] as allowed on functions (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 979cd54d452e · 2022-04-26T06:14:59.000-07:00
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Properly declare #[When] as allowed on functions | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Caught by the CI on PHP 8.2 Not sure why it didn't fail before, but this was missing for sure. Commits ------- a8fe12b [DependencyInjection] Properly declare #[When] as allowed on functions
diff --git a/src/Symfony/Component/DependencyInjection/Attribute/When.php b/src/Symfony/Component/DependencyInjection/Attribute/When.php
@@ -16,7 +16,7 @@
  *
  * @author Nicolas Grekas <p@tchwork.com>
  */
-#[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]
+#[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD | \Attribute::TARGET_FUNCTION | \Attribute::IS_REPEATABLE)]
 class When
 {
     public function __construct(

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`*`
`17`	`17`	`* @author Nicolas Grekas <p@tchwork.com>`
`18`	`18`	`*/`
`19`		`-#[\Attribute(\Attribute::TARGET_CLASS \| \Attribute::TARGET_METHOD \| \Attribute::IS_REPEATABLE)]`
	`19`	`+#[\Attribute(\Attribute::TARGET_CLASS \| \Attribute::TARGET_METHOD \| \Attribute::TARGET_FUNCTION \| \Attribute::IS_REPEATABLE)]`
`20`	`20`	`class When`
`21`	`21`	`{`
`22`	`22`	`public function __construct(`