[PasswordHasher] Skip test on nul byte for PHP versions that doesn't support it with Bcrypt

alexandre-daubois · alexandre-daubois · commit 93fcdb822da8 · 2024-05-07T10:11:09.000+02:00
diff --git a/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php b/src/Symfony/Component/PasswordHasher/Tests/Hasher/NativePasswordHasherTest.php
@@ -98,6 +98,13 @@ public function testBcryptWithLongPassword()
         $this->assertTrue($hasher->verify($hasher->hash($plainPassword), $plainPassword));
     }
 
+    /**
+     * "password_hash()" does not accept passwords containing NUL bytes prior to PHP 8.2
+     * and throws a ValueError, thus this test is skipped because `$hasher->verify()` will
+     * not be executed.
+     *
+     * @requires PHP >= 8.2
+     */
     public function testBcryptWithNulByte()
     {
         $hasher = new NativePasswordHasher(null, null, 4, \PASSWORD_BCRYPT);
diff --git a/src/Symfony/Component/PasswordHasher/Tests/Hasher/SodiumPasswordHasherTest.php b/src/Symfony/Component/PasswordHasher/Tests/Hasher/SodiumPasswordHasherTest.php
@@ -73,6 +73,13 @@ public function testBcryptWithLongPassword()
         $this->assertTrue($hasher->verify((new NativePasswordHasher(null, null, 4, \PASSWORD_BCRYPT))->hash($plainPassword), $plainPassword));
     }
 
+    /**
+     * "password_hash()" does not accept passwords containing NUL bytes prior to PHP 8.2
+     * and throws a ValueError, thus this test is skipped because `$hasher->verify()` will
+     * not be executed.
+     *
+     * @requires PHP >= 8.2
+     */
     public function testBcryptWithNulByte()
     {
         $hasher = new SodiumPasswordHasher(null, null);

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,13 @@ public function testBcryptWithLongPassword()`
`98`	`98`	`$this->assertTrue($hasher->verify($hasher->hash($plainPassword), $plainPassword));`
`99`	`99`	`}`
`100`	`100`
	`101`	`+ /**`
	`102`	`+ * "password_hash()" does not accept passwords containing NUL bytes prior to PHP 8.2`
	`103`	+ * and throws a ValueError, thus this test is skipped because `$hasher->verify()` will
	`104`	`+ * not be executed.`
	`105`	`+ *`
	`106`	`+ * @requires PHP >= 8.2`
	`107`	`+ */`
`101`	`108`	`public function testBcryptWithNulByte()`
`102`	`109`	`{`
`103`	`110`	`$hasher = new NativePasswordHasher(null, null, 4, \PASSWORD_BCRYPT);`
Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,13 @@ public function testBcryptWithLongPassword()`
`73`	`73`	`$this->assertTrue($hasher->verify((new NativePasswordHasher(null, null, 4, \PASSWORD_BCRYPT))->hash($plainPassword), $plainPassword));`
`74`	`74`	`}`
`75`	`75`
	`76`	`+ /**`
	`77`	`+ * "password_hash()" does not accept passwords containing NUL bytes prior to PHP 8.2`
	`78`	+ * and throws a ValueError, thus this test is skipped because `$hasher->verify()` will
	`79`	`+ * not be executed.`
	`80`	`+ *`
	`81`	`+ * @requires PHP >= 8.2`
	`82`	`+ */`
`76`	`83`	`public function testBcryptWithNulByte()`
`77`	`84`	`{`
`78`	`85`	`$hasher = new SodiumPasswordHasher(null, null);`