Make HttpClientTestCase compatible with PHPUnit8

jderusse · jderusse · commit 84a66908b51d · 2019-08-08T11:50:53.000+02:00
diff --git a/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php b/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php
@@ -21,16 +21,13 @@
  * A reference test suite for HttpClientInterface implementations.
  *
  * @experimental in 1.1
+ *
+ * @internal
  */
-abstract class HttpClientTestCase extends TestCase
+trait HttpClientTestCaseTrait
 {
     private static $server;
 
-    public static function setUpBeforeClass()
-    {
-        TestHttpServer::start();
-    }
-
     abstract protected function getHttpClient(string $testCase): HttpClientInterface;
 
     public function testGetRequest()
@@ -788,3 +785,28 @@ public function testGzipBroken()
         $response->getContent();
     }
 }
+
+if (method_exists(\ReflectionMethod::class, 'hasReturnType') && (new \ReflectionMethod(TestCase::class, 'setUpBeforeClass'))->hasReturnType()) {
+    abstract class HttpClientTestCase extends TestCase
+    {
+        use HttpClientTestCaseTrait;
+
+        public static function setUpBeforeClass(): void
+        {
+            TestHttpServer::start();
+        }
+    }
+} else {
+    abstract class HttpClientTestCase extends TestCase
+    {
+        use HttpClientTestCaseTrait;
+
+        /**
+         * @return void
+         */
+        public static function setUpBeforeClass()
+        {
+            TestHttpServer::start();
+        }
+    }
+}
