minor #13174 Clarify a comment (jakzal)

fabpot · fabpot · commit 7eaecbb78ce6 · 2015-01-02T08:54:59.000+01:00
This PR was merged into the 2.5 branch. Discussion ---------- Clarify a comment | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The previous comment was lying since [`collectViewVariables()`](https://github.com/symfony/symfony/blob/cffb64fd931d167c905f9bbecdb400e71cb3c850/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php#L165) doesn't really call the [`buildPreliminaryFormTree()`](https://github.com/symfony/symfony/blob/cffb64fd931d167c905f9bbecdb400e71cb3c850/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php#L186) nor the [`buildFinalFormTree()`](https://github.com/symfony/symfony/blob/cffb64fd931d167c905f9bbecdb400e71cb3c850/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php#L196). Commits ------- 00b4297 Clarify a comment.
diff --git a/src/Symfony/Component/Form/Extension/DataCollector/EventListener/DataCollectorListener.php b/src/Symfony/Component/Form/Extension/DataCollector/EventListener/DataCollectorListener.php
@@ -76,8 +76,7 @@ public function postSubmit(FormEvent $event)
             $this->dataCollector->collectSubmittedData($event->getForm());
 
             // Assemble a form tree
-            // This is done again in collectViewVariables(), but that method
-            // is not guaranteed to be called (i.e. when no view is created)
+            // This is done again after the view is built, but we need it here as the view is not always created.
             $this->dataCollector->buildPreliminaryFormTree($event->getForm());
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,7 @@ public function postSubmit(FormEvent $event)`
`76`	`76`	`$this->dataCollector->collectSubmittedData($event->getForm());`
`77`	`77`
`78`	`78`	`// Assemble a form tree`
`79`		`- // This is done again in collectViewVariables(), but that method`
`80`		`- // is not guaranteed to be called (i.e. when no view is created)`
	`79`	`+ // This is done again after the view is built, but we need it here as the view is not always created.`
`81`	`80`	`$this->dataCollector->buildPreliminaryFormTree($event->getForm());`
`82`	`81`	`}`
`83`	`82`	`}`