[Validator][DX] Add isEmpty() method to ConstraintViolationListInterface

fancyweb · fancyweb · commit 785ca883ca41 · 2019-07-25T09:45:59.000+02:00
diff --git a/src/Symfony/Component/Validator/CHANGELOG.md b/src/Symfony/Component/Validator/CHANGELOG.md
@@ -20,6 +20,7 @@ CHANGELOG
    `maxPropertyPath` options
  * added a new `notInRangeMessage` option to the `Range` constraint that will
    be used in the violation builder when both `min` and `max` are not null
+ * Added `isEmpty()` method to `ConstraintViolationListInterface`.
 
 4.3.0
 -----
diff --git a/src/Symfony/Component/Validator/ConstraintViolationList.php b/src/Symfony/Component/Validator/ConstraintViolationList.php
@@ -105,6 +105,14 @@ public function remove($offset)
         unset($this->violations[$offset]);
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function isEmpty(): bool
+    {
+        return empty($this->violations);
+    }
+
     /**
      * {@inheritdoc}
      *
diff --git a/src/Symfony/Component/Validator/ConstraintViolationListInterface.php b/src/Symfony/Component/Validator/ConstraintViolationListInterface.php
@@ -15,6 +15,8 @@
  * A list of constraint violations.
  *
  * @author Bernhard Schussek <bschussek@gmail.com>
+ *
+ * @method bool isEmpty() Is the list empty? - not implementing it is deprecated since Symfony 4.4
  */
 interface ConstraintViolationListInterface extends \Traversable, \Countable, \ArrayAccess
 {
diff --git a/src/Symfony/Component/Validator/Tests/ConstraintViolationListTest.php b/src/Symfony/Component/Validator/Tests/ConstraintViolationListTest.php
@@ -155,6 +155,19 @@ public function findByCodesProvider()
         ];
     }
 
+    public function testIsEmpty()
+    {
+        $list = new ConstraintViolationList();
+
+        $this->assertTrue($list->isEmpty());
+
+        $list->set(0, $this->getViolation('Error'));
+        $this->assertFalse($list->isEmpty());
+
+        $list->remove(0);
+        $this->assertTrue($list->isEmpty());
+    }
+
     protected function getViolation($message, $root = null, $propertyPath = null, $code = null)
     {
         return new ConstraintViolation($message, $message, [], $root, $propertyPath, null, null, $code);

Original file line number	Diff line number	Diff line change
`@@ -105,6 +105,14 @@ public function remove($offset)`
`105`	`105`	`unset($this->violations[$offset]);`
`106`	`106`	`}`
`107`	`107`
	`108`	`+ /**`
	`109`	`+ * {@inheritdoc}`
	`110`	`+ */`
	`111`	`+ public function isEmpty(): bool`
	`112`	`+ {`
	`113`	`+ return empty($this->violations);`
	`114`	`+ }`
	`115`	`+`
`108`	`116`	`/**`
`109`	`117`	`* {@inheritdoc}`
`110`	`118`	`*`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`	`* A list of constraint violations.`
`16`	`16`	`*`
`17`	`17`	`* @author Bernhard Schussek <bschussek@gmail.com>`
	`18`	`+ *`
	`19`	`+ * @method bool isEmpty() Is the list empty? - not implementing it is deprecated since Symfony 4.4`
`18`	`20`	`*/`
`19`	`21`	`interface ConstraintViolationListInterface extends \Traversable, \Countable, \ArrayAccess`
`20`	`22`	`{`