bug #51904 [HttpFoundation] do not access properties before initialization (xabbuh)

fabpot · fabpot · commit 74b4bbd6f4aa · 2023-10-10T07:58:00.000+02:00
This PR was merged into the 7.0 branch. Discussion ---------- [HttpFoundation] do not access properties before initialization | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT Commits ------- 6e19d1a do not access properties before initialization
diff --git a/src/Symfony/Component/HttpFoundation/Request.php b/src/Symfony/Component/HttpFoundation/Request.php
@@ -152,9 +152,9 @@ class Request
     protected string $defaultLocale = 'en';
 
     /**
-     * @var array<string, string[]>
+     * @var array<string, string[]>|null
      */
-    protected static array $formats;
+    protected static ?array $formats = null;
 
     protected static ?\Closure $requestFactory = null;
 
@@ -1499,7 +1499,11 @@ public function isNoCache(): bool
      */
     public function getPreferredFormat(?string $default = 'html'): ?string
     {
-        if ($this->preferredFormat ??= $this->getRequestFormat(null)) {
+        if (!isset($this->preferredFormat) && null !== $preferredFormat = $this->getRequestFormat(null)) {
+            $this->preferredFormat = $preferredFormat;
+        }
+
+        if ($this->preferredFormat ?? null) {
             return $this->preferredFormat;
         }
 
