bug #37130 [Console] allow cursor to be used even when STDIN is not defined (xabbuh)

fabpot · fabpot · commit 72ca171dbb29 · 2020-06-08T08:06:34.000+02:00
This PR was merged into the 5.1 branch. Discussion ---------- [Console] allow cursor to be used even when STDIN is not defined | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37124 | License | MIT | Doc PR | This allows to use the `Cursor` class introduced in Symfony 5.1 even when the `STDIN` constant is not defined. We did a similar bugfix in the past in the `QuestionHelper` class in #10798. Commits ------- aff1ffa allow cursor to be used even when STDIN is not defined
diff --git a/src/Symfony/Component/Console/Cursor.php b/src/Symfony/Component/Console/Cursor.php
@@ -21,10 +21,10 @@ final class Cursor
     private $output;
     private $input;
 
-    public function __construct(OutputInterface $output, $input = STDIN)
+    public function __construct(OutputInterface $output, $input = null)
     {
         $this->output = $output;
-        $this->input = $input;
+        $this->input = $input ?? (\defined('STDIN') ? STDIN : fopen('php://input', 'r+'));
     }
 
     public function moveUp(int $lines = 1): self

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,10 @@ final class Cursor`
`21`	`21`	`private $output;`
`22`	`22`	`private $input;`
`23`	`23`
`24`		`- public function __construct(OutputInterface $output, $input = STDIN)`
	`24`	`+ public function __construct(OutputInterface $output, $input = null)`
`25`	`25`	`{`
`26`	`26`	`$this->output = $output;`
`27`		`- $this->input = $input;`
	`27`	`+ $this->input = $input ?? (\defined('STDIN') ? STDIN : fopen('php://input', 'r+'));`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public function moveUp(int $lines = 1): self`