[Messenger] Narrow HandleMessageMiddleware::callHandler()’s $handler parameter to \Closure

TimWolla · TimWolla · commit 6944fde035ba · 2025-03-18T14:08:35.000+01:00
Since the previous commit this is guaranteed to be a `\Closure`. A microbenchmark using:

    &lt;?php

    function closure_(\Closure $f) {
    	$f('abc');
    }

    function callable_(callable $f) {
    	$f('abc');
    }

    for ($i = 0; $i &lt; 10000000; $i++) {
    	callable_(strrev(...));
    }

Indicates that using `\Closure` as the parameter type is roughly 10% faster:

    Benchmark 1: php callable.php
      Time (mean ± σ):     708.4 ms ±   5.8 ms    [User: 696.4 ms, System: 11.5 ms]
      Range (min … max):   699.5 ms … 715.7 ms    10 runs

    Benchmark 2: php closure.php
      Time (mean ± σ):     647.1 ms ±  21.0 ms    [User: 633.2 ms, System: 13.2 ms]
      Range (min … max):   626.7 ms … 683.7 ms    10 runs

    Summary
      php closure.php ran
        1.09 ± 0.04 times faster than php callable.php
diff --git a/src/Symfony/Component/Messenger/Middleware/HandleMessageMiddleware.php b/src/Symfony/Component/Messenger/Middleware/HandleMessageMiddleware.php
@@ -139,7 +139,7 @@ private function messageHasAlreadyBeenHandled(Envelope $envelope, HandlerDescrip
         return false;
     }
 
-    private function callHandler(callable $handler, object $message, ?Acknowledger $ack, ?HandlerArgumentsStamp $handlerArgumentsStamp): mixed
+    private function callHandler(\Closure $handler, object $message, ?Acknowledger $ack, ?HandlerArgumentsStamp $handlerArgumentsStamp): mixed
     {
         $arguments = [$message];
         if (null !== $ack) {

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ private function messageHasAlreadyBeenHandled(Envelope $envelope, HandlerDescrip`
`139`	`139`	`return false;`
`140`	`140`	`}`
`141`	`141`
`142`		`- private function callHandler(callable $handler, object $message, ?Acknowledger $ack, ?HandlerArgumentsStamp $handlerArgumentsStamp): mixed`
	`142`	`+ private function callHandler(\Closure $handler, object $message, ?Acknowledger $ack, ?HandlerArgumentsStamp $handlerArgumentsStamp): mixed`
`143`	`143`	`{`
`144`	`144`	`$arguments = [$message];`
`145`	`145`	`if (null !== $ack) {`