bug #25559 [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 6935e5a4aa5f · 2017-12-20T13:20:53.000+01:00
This PR was merged into the 3.3 branch. Discussion ---------- [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25511 | License | MIT | Doc PR | - Commits ------- 0d4bce6 [Process] Dont use getenv(), it returns arrays and can introduce subtle breaks accros PHP versions
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -1718,15 +1718,11 @@ private function escapeArgument($argument)
 
     private function getDefaultEnv()
     {
-        if (\PHP_VERSION_ID >= 70100) {
-            $env = getenv();
-        } else {
-            $env = array();
+        $env = array();
 
-            foreach ($_SERVER as $k => $v) {
-                if (is_string($v) && false !== $v = getenv($k)) {
-                    $env[$k] = $v;
-                }
+        foreach ($_SERVER as $k => $v) {
+            if (is_string($v) && false !== $v = getenv($k)) {
+                $env[$k] = $v;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1718,15 +1718,11 @@ private function escapeArgument($argument)`
`1718`	`1718`
`1719`	`1719`	`private function getDefaultEnv()`
`1720`	`1720`	`{`
`1721`		`- if (\PHP_VERSION_ID >= 70100) {`
`1722`		`- $env = getenv();`
`1723`		`- } else {`
`1724`		`- $env = array();`
	`1721`	`+ $env = array();`
`1725`	`1722`
`1726`		`- foreach ($_SERVER as $k => $v) {`
`1727`		`- if (is_string($v) && false !== $v = getenv($k)) {`
`1728`		`- $env[$k] = $v;`
`1729`		`- }`
	`1723`	`+ foreach ($_SERVER as $k => $v) {`
	`1724`	`+ if (is_string($v) && false !== $v = getenv($k)) {`
	`1725`	`+ $env[$k] = $v;`
`1730`	`1726`	`}`
`1731`	`1727`	`}`
`1732`	`1728`