[Serializer] Support canners in object normalizer

Rokas Mikalkėnas · Rokas Mikalkėnas · commit 61d2e0b4135d · 2022-03-08T10:38:29.000+02:00
diff --git a/src/Symfony/Component/Serializer/CHANGELOG.md b/src/Symfony/Component/Serializer/CHANGELOG.md
@@ -12,6 +12,7 @@ CHANGELOG
  * Deprecate `ContextAwareDecoderInterface`, use `DecoderInterface` instead
  * Deprecate supporting denormalization for `AbstractUid` in `UidNormalizer`, use one of `AbstractUid` child class instead
  * Deprecate denormalizing to an abstract class in `UidNormalizer`
+ * Add support for `can*()` methods to `ObjectNormalizer`
 
 6.0
 ---
diff --git a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
@@ -86,8 +86,8 @@ protected function extractAttributes(object $object, string $format = null, arra
             $name = $reflMethod->name;
             $attributeName = null;
 
-            if (str_starts_with($name, 'get') || str_starts_with($name, 'has')) {
-                // getters and hassers
+            if (str_starts_with($name, 'get') || str_starts_with($name, 'has') || str_starts_with($name, 'can')) {
+                // getters, hassers and canners
                 $attributeName = substr($name, 3);
 
                 if (!$reflClass->hasProperty($attributeName)) {
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectDummy.php b/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectDummy.php
@@ -13,6 +13,7 @@ class ObjectDummy
     private $baz;
     protected $camelCase;
     protected $object;
+    private $go;
 
     public function getFoo()
     {
@@ -63,4 +64,14 @@ public function getObject()
     {
         return $this->object;
     }
+
+    public function setGo($go)
+    {
+        $this->go = $go;
+    }
+
+    public function canGo()
+    {
+        return $this->go;
+    }
 }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -107,6 +107,7 @@ public function testNormalize()
         $obj->setBaz(true);
         $obj->setCamelCase('camelcase');
         $obj->setObject($object);
+        $obj->setGo(true);
 
         $this->serializer
             ->expects($this->once())
@@ -123,6 +124,7 @@ public function testNormalize()
                 'fooBar' => 'foobar',
                 'camelCase' => 'camelcase',
                 'object' => 'string_object',
+                'go' => true,
             ],
             $this->normalizer->normalize($obj, 'any')
         );
@@ -669,6 +671,7 @@ public function testNormalizeNotSerializableContext()
             'camelCase' => null,
             'object' => null,
             'bar' => null,
+            'go' => null,
         ];
 
         $this->assertEquals($expected, $this->normalizer->normalize($objectDummy, null, ['not_serializable' => function () {
@@ -805,6 +808,7 @@ public function testDefaultObjectClassResolver()
         $obj->setBaz(true);
         $obj->setCamelCase('camelcase');
         $obj->unwantedProperty = 'notwanted';
+        $obj->setGo(false);
 
         $this->assertEquals(
             [
@@ -814,6 +818,7 @@ public function testDefaultObjectClassResolver()
                 'fooBar' => 'foobar',
                 'camelCase' => 'camelcase',
                 'object' => null,
+                'go' => false,
             ],
             $normalizer->normalize($obj, 'any')
         );
@@ -842,6 +847,7 @@ public function testObjectClassResolver()
                 'fooBar' => 'foobar',
                 'camelCase' => 'camelcase',
                 'object' => null,
+                'go' => null,
             ],
             $normalizer->normalize($obj, 'any')
         );

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ class ObjectDummy`
`13`	`13`	`private $baz;`
`14`	`14`	`protected $camelCase;`
`15`	`15`	`protected $object;`
	`16`	`+ private $go;`
`16`	`17`
`17`	`18`	`public function getFoo()`
`18`	`19`	`{`
`@@ -63,4 +64,14 @@ public function getObject()`
`63`	`64`	`{`
`64`	`65`	`return $this->object;`
`65`	`66`	`}`
	`67`	`+`
	`68`	`+ public function setGo($go)`
	`69`	`+ {`
	`70`	`+ $this->go = $go;`
	`71`	`+ }`
	`72`	`+`
	`73`	`+ public function canGo()`
	`74`	`+ {`
	`75`	`+ return $this->go;`
	`76`	`+ }`
`66`	`77`	`}`