Skip to content

Commit 5126639

Browse files
fabpotfabpot
committed
feature #20197 [WebProfilerBundle] Improve Ajax Profiling Performance (javascript) (patrick-mcdougle)
This PR was squashed before being merged into the 3.3-dev branch (closes #20197). Discussion ---------- [WebProfilerBundle] Improve Ajax Profiling Performance (javascript) | Q | A | | --- | --- | | Branch? | master | | Bug fix? | kinda (is bad performance a bug?) | | New feature? | kinda (is increased performance a feature?) | | BC breaks? | no (unless performance is a BC break) | | Deprecations? | no | | Tests pass? | do we have JS tests? | | Fixed tickets | #20155 | | License | MIT | | Doc PR | n/a | The old version of this JS re-rendered the entire list of ajax calls which was causing some performance issues when people had high numbers of ajax requests (increasingly common as people create SPAs. This PR changes the behavior of the ajax profiler to be more smart about the DOM manipulations it makes. Instead of re-rendering the entire list, on any AJAX requests/responses, it instead adds the row to the profiler when an AJAX request is made, adding the DOM node as a property of the request on the requestStack. When the AJAX response comes back, it updates the existing DOM node instead of re-creating it (and all of the others). I've tested this on my machine using a modern version of chrome. I don't think I'm doing anything fancy, so I think the likelihood that I broke something is minimal. I've left a couple of the commits separate, because they represent distinct ideas. The first commit is just some consistency/cleanup. The second commit is the meat of the work. Its diff is basically useless since I've added two new functions and modified one function heavily. I tried to make the diff as easy to read as possible, but it's still pretty rough. The third commit removes some functions/calls that I don't think need to be there now that this is re-written, but I wanted to leave them in a separate commit for ease of revert if they are indeed needed. Commits ------- 65e391c Replace occurances of querySelectorAll with querySelector fddff26 Put back the indentation 9942edd Remove unnecessary method calls/definitions 2c053ee Rewrite ajax profiling for performance da621c9 Fix indentation & JS Cleanup
2 parents 90df479 + 65e391c commit 5126639

File tree

2 files changed

+186
-201
lines changed

2 files changed

+186
-201
lines changed

0 commit comments

Comments
 (0)