use copy() instead of rename() on Windows

xabbuh · xabbuh · commit 37585ebdd2da · 2024-07-06T07:14:17.000+02:00
On Windows depending on the PHP version rename() can fail if the target
file is being executed. Since the source file is not used by another
process using copy() instead should be safe to be used.
diff --git a/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php b/src/Symfony/Component/Cache/Traits/FilesystemCommonTrait.php
@@ -114,7 +114,12 @@ private function write(string $file, string $data, ?int $expiresAt = null)
                 touch($this->tmp, $expiresAt ?: time() + 31556952); // 1 year in seconds
             }
 
-            $success = rename($this->tmp, $file);
+            if ('\\' === \DIRECTORY_SEPARATOR) {
+                $success = copy($this->tmp, $file);
+            } else {
+                $success = rename($this->tmp, $file);
+            }
+
             $unlink = !$success;
 
             return $success;
