Skip to content

Commit 37282f7

Browse files
committed
minor #53335 [Form]  skip some tests that do not work with ICU 71.1/72.1 (xabbuh)
This PR was merged into the 5.4 branch. Discussion ---------- [Form]  skip some tests that do not work with ICU 71.1/72.1 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | replaces #52967 | License | MIT Commits ------- 8ef61d9 skip some tests that do not work with ICU 71.1/72.1
2 parents 8a2d721 + 8ef61d9 commit 37282f7

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ public function testSubmitFromSingleTextDateTime()
9191
// we test against "de_DE", so we need the full implementation
9292
IntlTestHelper::requireFullIntl($this, false);
9393

94-
if ('71.1' === Intl::getIcuVersion()) {
95-
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
94+
if (\in_array(Intl::getIcuVersion(), ['71.1', '72.1'], true)) {
95+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1/72.1.');
9696
}
9797

9898
\Locale::setDefault('de_DE');
@@ -117,8 +117,8 @@ public function testSubmitFromSingleTextDateTimeImmutable()
117117
// we test against "de_DE", so we need the full implementation
118118
IntlTestHelper::requireFullIntl($this, false);
119119

120-
if ('71.1' === Intl::getIcuVersion()) {
121-
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
120+
if (\in_array(Intl::getIcuVersion(), ['71.1', '72.1'], true)) {
121+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1/72.1.');
122122
}
123123

124124
\Locale::setDefault('de_DE');
@@ -144,8 +144,8 @@ public function testSubmitFromSingleTextString()
144144
// we test against "de_DE", so we need the full implementation
145145
IntlTestHelper::requireFullIntl($this, false);
146146

147-
if ('71.1' === Intl::getIcuVersion()) {
148-
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
147+
if (\in_array(Intl::getIcuVersion(), ['71.1', '72.1'], true)) {
148+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1/72.1.');
149149
}
150150

151151
\Locale::setDefault('de_DE');
@@ -170,8 +170,8 @@ public function testSubmitFromSingleTextTimestamp()
170170
// we test against "de_DE", so we need the full implementation
171171
IntlTestHelper::requireFullIntl($this, false);
172172

173-
if ('71.1' === Intl::getIcuVersion()) {
174-
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
173+
if (\in_array(Intl::getIcuVersion(), ['71.1', '72.1'], true)) {
174+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1/72.1.');
175175
}
176176

177177
\Locale::setDefault('de_DE');
@@ -198,8 +198,8 @@ public function testSubmitFromSingleTextRaw()
198198
// we test against "de_DE", so we need the full implementation
199199
IntlTestHelper::requireFullIntl($this, false);
200200

201-
if ('71.1' === Intl::getIcuVersion()) {
202-
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
201+
if (\in_array(Intl::getIcuVersion(), ['71.1', '72.1'], true)) {
202+
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1/72.1.');
203203
}
204204

205205
\Locale::setDefault('de_DE');

0 commit comments

Comments
 (0)