[CssSelector] Fix CSS identifiers parsing - they can start with dash

jakubkulhan · jakubkulhan · commit 346be01d7bcb · 2018-03-08T00:00:26.000+01:00
diff --git a/src/Symfony/Component/CssSelector/Parser/Tokenizer/TokenizerPatterns.php b/src/Symfony/Component/CssSelector/Parser/Tokenizer/TokenizerPatterns.php
@@ -43,7 +43,7 @@ public function __construct()
         $this->stringEscapePattern = $this->newLineEscapePattern.'|'.$this->escapePattern;
         $this->nonAsciiPattern = '[^\x00-\x7F]';
         $this->nmCharPattern = '[_a-z0-9-]|'.$this->escapePattern.'|'.$this->nonAsciiPattern;
-        $this->nmStartPattern = '[_a-z]|'.$this->escapePattern.'|'.$this->nonAsciiPattern;
+        $this->nmStartPattern = '[_a-z-]|'.$this->escapePattern.'|'.$this->nonAsciiPattern;
         $this->identifierPattern = '(?:'.$this->nmStartPattern.')(?:'.$this->nmCharPattern.')*';
         $this->hashPattern = '#((?:'.$this->nmCharPattern.')+)';
         $this->numberPattern = '[+-]?(?:[0-9]*\.[0-9]+|[0-9]+)';
diff --git a/src/Symfony/Component/CssSelector/Tests/Parser/ParserTest.php b/src/Symfony/Component/CssSelector/Tests/Parser/ParserTest.php
@@ -186,6 +186,7 @@ public function getPseudoElementsTestData()
             array('foo:after', 'Element[foo]', 'after'),
             array('foo::selection', 'Element[foo]', 'selection'),
             array('lorem#ipsum ~ a#b.c[href]:empty::selection', 'CombinedSelector[Hash[Element[lorem]#ipsum] ~ Pseudo[Attribute[Class[Hash[Element[a]#b].c][href]]:empty]]', 'selection'),
+            array('video::-webkit-media-controls', 'Element[video]', '-webkit-media-controls'),
         );
     }
 

Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,7 @@ public function getPseudoElementsTestData()`
`186`	`186`	`array('foo:after', 'Element[foo]', 'after'),`
`187`	`187`	`array('foo::selection', 'Element[foo]', 'selection'),`
`188`	`188`	`array('lorem#ipsum ~ a#b.c[href]:empty::selection', 'CombinedSelector[Hash[Element[lorem]#ipsum] ~ Pseudo[Attribute[Class[Hash[Element[a]#b].c][href]]:empty]]', 'selection'),`
	`189`	`+ array('video::-webkit-media-controls', 'Element[video]', '-webkit-media-controls'),`
`189`	`190`	`);`
`190`	`191`	`}`
`191`	`192`